Code Monkey home page Code Monkey logo

Comments (14)

tadakongithub avatar tadakongithub commented on September 25, 2024 1

Thanks! I was able to run pytest locally. Also formatted the code with black. I should be able to make a PR soon.

from climatemind-backend.

tadakongithub avatar tadakongithub commented on September 25, 2024

I'd like take on this task. Is there any deadline?

from climatemind-backend.

danmash avatar danmash commented on September 25, 2024

Hi @tadakongithub! Thank you for your interest, I really appreciate this 👍
There's no deadline. I'll send a follow-up in the comments in some time if no progress.
Feel free to ask any questions here or via chat https://t.me/climatemind_chat

from climatemind-backend.

tadakongithub avatar tadakongithub commented on September 25, 2024

Ok. I'll try my best to make progress as quickly as possible. I'm learning Cypress and Pytest, so it might take a little time.

from climatemind-backend.

tadakongithub avatar tadakongithub commented on September 25, 2024

Hi. I'm a bit new to making tests and python app in general. While I'm writing in vs code, it says import "pytest" could not be resolved. Same goes for flask. Can you advise what I'm doing wrong?

from climatemind-backend.

danmash avatar danmash commented on September 25, 2024

@tadakongithub to make able to run the project and pytest you need to setup your docker environment first. Please make sure you follow the guide
Let me know if you have any problems with the installation.

Then you should be able to run any command in your docker container and connect to running containers from your IDE

from climatemind-backend.

tadakongithub avatar tadakongithub commented on September 25, 2024

Just made a PR. Let me know if I need to make any changes

from climatemind-backend.

danmash avatar danmash commented on September 25, 2024

Thank you! I really appreciate this 👍

from climatemind-backend.

tadakongithub avatar tadakongithub commented on September 25, 2024

I used to be able to create a pull request from a working branch of my forked repo to the develop branch of the upstream repo. Now I can't seem to do that. Did something change? Should I push directly to the develop branch of the upstream repo?

from climatemind-backend.

danmash avatar danmash commented on September 25, 2024

@tadakongithub it's probably due to the fact that you already have the PR and all new changes go there.
@brianpeiris can you please advise on this?

from climatemind-backend.

brianpeiris avatar brianpeiris commented on September 25, 2024

@tadakongithub You should be able to create multiple pull requests from your fork, but they have to be on unique branches with different names. Is that what you're running into?
I don't have full access to the repo settings here, but I assume nothing changed there. I'm still able to create PRs from my fork.

from climatemind-backend.

brianpeiris avatar brianpeiris commented on September 25, 2024

We can close this now that #477 is merged. Thanks!

from climatemind-backend.

tadakongithub avatar tadakongithub commented on September 25, 2024

Now that it's merged, the pull request screen looks how it originally looked and it seems I can make a new PR now. I wonder if I cannot make multiple PR from my fork. Or maybe it was simply because my added commits went to the same PR I made.

Thanks for reviewing!

from climatemind-backend.

brianpeiris avatar brianpeiris commented on September 25, 2024

You should definitely be able to open multiple PRs from your fork. I've done that a few times for this project. They just have to be from separate branches.
Let us know if you run into that issue again.

from climatemind-backend.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.