Describe the feature or problem you’d like to solve Provides progr

Provides progress during extension installation about cli HOT 3 OPEN

MC-XiaoHei commented on June 15, 2024 2

Provides progress during extension installation

from cli.

Comments (3)

mxie commented on June 15, 2024

Thanks for your suggestion!

Can you tell us more about what kind of progress indicator would be helpful? What kind of information would you like with it?

from cli.

MC-XiaoHei commented on June 15, 2024

thanks
I hope to be similar to this, providing a progress bar, a percentage, I think this can better alleviate the user 's waiting anxiety.

Downloading aaa plugin
[xxxxxxxxxxxxx------------------] 43%

or maybe others have better idea

from cli.

williammartin commented on June 15, 2024

The code right now isn't really structured to support this very well but it's definitely a reasonable enhancement request. Most likely what we'd want to do is set up a progress bar based on the resp.ContentLength field and then as we read the resp.Body into the file we also tee it into the progress bar so that it can fill.

cli/pkg/cmd/extension/http.go

Lines 85 to 106 in 24481c5

    
           var resp *http.Response 
        
           if resp, downloadErr = httpClient.Do(req); downloadErr != nil { 
        
           	return 
        
           } 
        
           defer resp.Body.Close() 
        
           if resp.StatusCode > 299 { 
        
           	downloadErr = api.HandleHTTPError(resp) 
        
           	return 
        
           } 
        
           var f *os.File 
        
           if f, downloadErr = os.OpenFile(destPath, os.O_CREATE|os.O_WRONLY|os.O_TRUNC, 0755); downloadErr != nil { 
        
           	return 
        
           } 
        
           defer func() { 
        
           	if err := f.Close(); downloadErr == nil && err != nil { 
        
           		downloadErr = err 
        
           	} 
        
           }() 
        
           _, downloadErr = io.Copy(f, resp.Body)

If we did this, we'd also want to consider accessibility. The current spinner is pretty bad because screen readers read a bunch of dots but if we're going to do the work to implement a real file download progress bar we'd want to treat accessibility as a first class concern.

from cli.

Recommend Projects

Provides progress during extension installation about cli HOT 3 OPEN

Comments (3)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	var resp *http.Response
	if resp, downloadErr = httpClient.Do(req); downloadErr != nil {
	return
	}
	defer resp.Body.Close()

	if resp.StatusCode > 299 {
	downloadErr = api.HandleHTTPError(resp)
	return
	}

	var f *os.File
	if f, downloadErr = os.OpenFile(destPath, os.O_CREATE\|os.O_WRONLY\|os.O_TRUNC, 0755); downloadErr != nil {
	return
	}
	defer func() {
	if err := f.Close(); downloadErr == nil && err != nil {
	downloadErr = err
	}
	}()

	_, downloadErr = io.Copy(f, resp.Body)