gh pr testing results about cli HOT 4 CLOSED

This is great @tierninho!

For the "Should still show?" for gh pr list I think not showing closed PRs makes sense there.

For "Should we show if closed?" for gh pr checkout 1 I think it makes sense to still allow a checkout even if the branch is closed.

from cli.

@tierninho This is really thorough, thank you!

gh pr list 11 or gh pr list aaaa | still shows all three areas | on the fence about this

The gh pr list command doesn't take any extra arguments. When you pass 11 or aaaa, the argument is ignored. Would you prefer that an error message is shown instead? We could easily do that.

Closed PR | “You have no pull requests to review” | Should still show?

Good question! For now we're focusing on open PRs only.

gh pr show 2 | Still open if an issue?

Good catch. Not sure if we should avoid opening the browser if we detect that "2" is an issue instead of a PR in this case. For now I'd vote that we leave the current behavior and see if we get user feedback on this one?

All other feedback on show, checkout, create commands: fully agree! Especially when it comes to failing fast during create instead of allowing an API call to go through and ending up with a 422 error that we could have avoided earlier. ✨

from cli.

Would you prefer that an error message is shown instead? We could easily do that.

Let's leave alone for now see if we get user feedback on this one, too.

Good catch. Not sure if we should avoid opening the browser if we detect that "2" is an issue instead of a PR in this case. For now I'd vote that we leave the current behavior and see if we get user feedback on this one?

👍

from cli.

Closing this for now as the product is evolving.

from cli.