Code Monkey home page Code Monkey logo

Comments (1)

mqrause avatar mqrause commented on June 10, 2024 1

As for the crash, from what I can see in this

Cataclysm-DDA/src/item.cpp

Lines 11603 to 11607 in 1797b40

bool ammo_in_container = ammo->is_ammo_container();
bool ammo_in_liquid_container = ammo->is_watertight_container();
item &ammo_obj = ( ammo_in_container || ammo_in_liquid_container ) ?
// this is probably not the right way to do this. there is no guarantee whatsoever that ammo_obj will be an ammo
*ammo->contents.all_items_top( pocket_type::CONTAINER ).front() : *ammo;

The issue is that is_watertight_container does not check if there are any actual contents inside (is_ammo_container does), so the call to all_items_top().front() causes undefined behavior when it really doesn't contain anything.
That does need a fix, although I wonder if the real issue might be that the reload option was formed in the first place?

from cataclysm-dda.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.