User name not showing when logging in with Google about pup HOT 7 CLOSED

Hi @pilarArr having trouble confirming this one. When logging in with multiple Google accounts and a fresh Meteor.users collection, the username is displaying as expected. Can you provide a screencap/video of what you're experiencing?

from pup.

Hi @cleverbeagle,
Sorry for the delay, this would be the screencap of what I'm seeing, I also deleted the users collection before trying like you said and still nothing. I also tried with different google accounts and still got the same.

from pup.

Also this is the entry that is created in the Mongo Collection.
Because my profile is empty every time, the name is always empty and this only happens with Google, with Facebook it works.

from pup.

Pretty sure It's because OAuth uses Google (plus) to retrieve first and last name, and you don't have any.

from pup.

Interesting! Kind of wonky on Google's part, but makes sense as to why we'd see the difference. I'm not sure if we should qualify this as a bug since it's technically working as expected. Maybe the fix here is to just display the email address if we detect an empty name string?

P.S. @pilarArr and @zeiitoun do you have an email I can get in touch at (or could you email [email protected])? Wanted to see if either of you would be interested in helping with Pup.

from pup.

In the meteor documentation, it's specified that you can add options for google services when you call Meteor.loginWithGoogle. (here)

This options may include Google’s additional URI parameters (https://developers.google.com/identity/protocols/OpenIDConnect#authenticationuriparameters) such as the "scope" that might be interesting here.

You could modify the login scope to "https://www.googleapis.com/auth/plus.login"? Which will ask the user to subscribe to Google Plus if he doesn't have any account.
(bonus point : It's the recommended login scope, meteor should change to this one)

(I will email you tonight or tomorrow, love your project ;))

from pup.

I went around this by changing the option requestPermissions to ['email', 'profile']. That fills the profile and fixes the empty name.

I'm not sure everyone wants to have a Google Plus account to sign up with their Google account, seems like an unnecessary extra step to create a Google Plus account just to sing up with Google, but that's just my newbie opinion 😕

P.S. @cleverbeagle I've sent you an email 😄

from pup.