number_field without setting the value gives an error in Rails 3. about delocalize HOT 6 CLOSED

If you look at the implementation of number_field, you will see the following:

  def to_number_field_tag(field_type, options = {})
    options = options.stringify_keys
    options['size'] ||= nil

    if range = options.delete("in") || options.delete("within")
      options.update("min" => range.min, "max" => range.max)
    end
    to_input_field_tag(field_type, options)
  end

https://github.com/rails/rails/blob/v3.2.9/actionpack/lib/action_view/helpers/form_helper.rb#L1049

In other words, if you use number_field, you need to pass in or within
as options.

On Wed, Jan 2, 2013 at 3:41 PM, mxtopher [email protected] wrote:

If I use delocalize, all my number_fields must explicitly set the value:

= f.number_field :foo, value: 2

If I omit it, as in

= f.number_field :foo

I get

"can't convert Symbol into Integer"

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/53.

from delocalize.

Sorry for getting to this so late.

@fernandoluizao: Not sure you're right here. Neither parameter is required because if it's blank it will just skip the if construct.

@mxtopher: Could you please provide a failing test? I'm happy to investigate and fix it if you can't/won't do it but a failing test would be great. :)

from delocalize.

I'll provide it tonight/tomorrow. ;)

from delocalize.

... I am in working time. Besides, I'll have to learn how to create tests
(Which is a good thing, thank you [= )

from delocalize.

Sure, take your time. :) I probably won't get to it before the weekend anyway.

from delocalize.

1.0.0 is out which doesn't patch ActionView any longer. You can manually override the output as you see fit.

from delocalize.