Code Monkey home page Code Monkey logo

Comments (3)

nelsonpecora avatar nelsonpecora commented on August 23, 2024

The fix for this is:

  • use underscored routes by default
  • add a --amphora-version <integer> flag
  • if the amphora version is set to 4 (or lower), use non-underscored routes

(note: we're doing this, rather than a binary --no-underscored-routes flag, because the amphora api might change in future versions. this way, we'll be able to use claycli with multiple amphora versions without having to checkout different claycli versions, which is a hassle)

from claycli.

nelsonpecora avatar nelsonpecora commented on August 23, 2024

Actually, we'd need to split it into two flags anyway (it's possible to import from an old version of amphora to a new version), and this is a common enough use case that it should be fast to write. Thus, we should do:

  • --amphora-legacy, -a use non-underscored api routes (applies like --key)
  • --source-amphora-legacy, -A use non-underscored api routes (applies like --source-key)

from claycli.

nelsonpecora avatar nelsonpecora commented on August 23, 2024

We're actually going to handle this dynamically, but for now I've made a major version of claycli with hardcoded underscore support.

from claycli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.