Comments (7)
This is somewhat mitigated with large histories, obviously. New windows and
tabs fix the problem.
Original comment by [email protected]
on 5 Feb 2011 at 5:24
from tenfourfox.
The awesome bar appears to still be here and still gets events. You can TAB to
(invisible) suggestions, and you can use arrow keys. Perhaps it's not that the
awesome bar is invisible but that it's behind the window it's attached to.
Original comment by [email protected]
on 14 Feb 2011 at 12:00
from tenfourfox.
However, other things that make the awesome bar drop down disappear allow it to
come back later, so there must be something specific about underflowing the
result.
Original comment by [email protected]
on 14 Feb 2011 at 1:06
from tenfourfox.
Things that it is not:
- It is not due to our fix for issue 9 (backing that out made no difference)
- It is not due to ClosePopup() in
toolkit/components/autocomplete/src/nsAutoCompleteController.cpp (making the
function return NS_OK made no difference; the popup still closed)
Currently homing in on toolkit/content/widgets/autocomplete.xml ...
Original comment by [email protected]
on 14 Feb 2011 at 2:39
from tenfourfox.
Making the changes to the autocomplete widget had unexpected side effects. So
we took a different tack.
The only time that the awesome bar goes bad is when it runs out of suggestions
-- other things that close it work (for reasons unclear to me). Since I'm not
sure how to fix that, the other solution is ... never let it run out of
suggestions. If toolkit/components/places/src/nsPlacesAutoComplete.js finds
that no matches are returned, it makes a bogus placeholder that is blank, so it
just looks like a blank dropdown. This is totally shippable, and totally works
-- the awesomebar now functions otherwise normally.
Until I figure out how to get rid of that, this is an acceptable compromise (so
issues complaining about the blank Awesome bar will be wontfixed unless the
real cause is discovered). This has no other side effects, so this is now
Verified.
Original comment by [email protected]
on 16 Feb 2011 at 6:04
- Changed state: Verified
from tenfourfox.
Side-effect alert:
This breaks at least the Omnibar and Cybersearch plugins and possibly many
others, causing them to delete the contents of the URL bar whenever the blank
placeholder would normally appear, it took me a while to correlate it to this
bugfix.
In addition to causing extension problems, I'm thinking this bugfix might be
problematic when Mozilla retires the search box, as it seems to interfere with
anything wanting to serve up search suggestions in the awesome bar.
Original comment by [email protected]
on 1 Feb 2013 at 2:15
from tenfourfox.
Please post the screenshot I asked for in the tenderapp ticket; I'm already
aware of the issue.
Original comment by [email protected]
on 4 Feb 2013 at 4:49
from tenfourfox.
Related Issues (20)
- Update Reader View to 0.4.1 HOT 1
- Security and patch rollup for FPR31 from ESR78
- Security and patch rollup for FPR32 from ESR78
- please consider a short note about where patches are found and process to apply HOT 1
- FPR32.1 HOT 1
- FPR32.2 HOT 1
- FPR32.3
- FPR32.4 HOT 1
- FPR32.5
- Default Site-Specific User-Agent HOT 1
- Cannot access if port number is larger than 32767 HOT 1
- candidate patches HOT 12
- zip error: Not supported (uzoff_t not same size as zoff_t) HOT 5
- async/await using external mozjs? HOT 3
- consider global polyfill HOT 1
- ppc64 and building with newer gcc? HOT 17
- Not working on OSX 10.4.7, says wrong OS version. iBook G4 (7450). HOT 1
- Possible to make Tor-TFF? HOT 6
- Copile error "error: 'log2' is not a member of 'std'" on G5 with MacOS 10.5.8 HOT 2
- Allow CSS grid to be configurable by host pref
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tenfourfox.