Expose `Clash.Class.Counter` methods about clash-compiler HOT 9 CLOSED

We could also add an instance for Counter a => Maybe a
And then you can get your interface with:

countSuccChecked :: Counter a => a -> Maybe a
countSuccChecked = countSucc . Just

from clash-compiler.

Also I think we should probably add instances for Bool and Bit

from clash-compiler.

I think the API I would prefer is one that consists of countMin, and countSuccChecked :: (Counter a) => a -> Maybe a. Then both countSucc and countSuccOverflow are trivially recoverable:

countSucc = fromMaybe countMin . countSuccChecked
countSuccOverflow = maybe (True, countMin) (False,) . countSuccChecked

from clash-compiler.

The nice thing about (Bool, a) is that you don't need a branch to determine the overflowed number. While this is a bit of a micro-optimization, I do feel it's the right thing to do.

How about simply moving the internal functions public? I don't think we discovered any downsides to the private API so far, so as far as I'm concerned it's fine as it is.

from clash-compiler.

Are there any plans to implement this?

from clash-compiler.

Would simply exposing the internal functions be okay? In that case, it's easily done.

from clash-compiler.

@gergoerdi I'd be happy to move this forward; could you comment on my replies?

from clash-compiler.

I'm happy with the suggested ways of doing thidls, because the Maybe instance would give me what I need.

from clash-compiler.

See #2692

from clash-compiler.