[FEAT] Add support for lifecycle ignored tags about terraform-azurerm-rg HOT 4 CLOSED

Hello @mloskot ,
Thanks for your suggestion!

At Claranet we already handle this with our internal tagging policy and this module: https://github.com/claranet/terraform-claranet-default-tags

I think you may want to create your own module with your needs. Adding theses default tags on every modules we have will requires lots of maintenance.

from terraform-azurerm-rg.

Hi @Shr3ps, although such module is a very neat idea, I have just noticed I missed a very important detail in my suggestion: lifecycle and ignore_changes. I meant tags which are created once per a resource lifetime:

resource "azurerm_resource_group" "main" {
  name     = data.azurecaf_name.main_rg.result
  location = module.azure_region.location

  tags = {
    created_at = timestamp()
    created_by = data.azuread_directory_object.terraform.object_id
  }

  lifecycle {
    ignore_changes = [
      tags["created_at"],
      tags["created_by"],
    ]
  }

AFAIK, there is no way to inject such lifecycle configuration into resources created by modules. Unless, source code of such modules is modified.

Adding theses default tags on every modules we have will requires lots of maintenance.

Yes, I'm aware this issue may be a blocker here.

from terraform-azurerm-rg.

Hey,

For your tag created_at (which IMO should be updated_at instead), no lifecycle ingore_changes is needed if you use a time_static resource (https://registry.terraform.io/providers/hashicorp/time/latest/docs/resources/static) instead of the timestamp() builtin which is evaluated every time.

and for your created_by, I don't get also why you need to ignore it, best practices would be to use a CD/pipeline to apply terraform stacks, which means using an Identity, a Service Principal or a Service account - that don't change.

from terraform-azurerm-rg.

@Shr3ps

no lifecycle ingore_changes is needed if you use a time_static resource

I was not aware of this module. Thanks a lot @Shr3ps !

for your created_by, I don't get also why you need to ignore it, best practices would be to use a CD/pipeline to apply terraform stacks, which means using an Identity, a Service Principal or a Service account - that don't change.

Yes, you are right about the pipelines recommendation.
In that particular case, I mixed cases of running terraform plan|apply by human operator (User account) and CI pipeline (Service Principal). It's an edge case though.

from terraform-azurerm-rg.