Comments (2)
You either pay for this with a slightly off-center prior either when j=0 or
j=trg.size() - 1-- I noticed this after I had run all the experiments and
decided not to fix it, but a couple people have pointed it out, so it's
probably worth fixing at some point...
On Mon, Sep 23, 2013 at 12:27 PM, dreugeworst [email protected]:
shouldn't line 225 use j+1 instead of j?
emp_feat += DiagonalAlignment::Feature(j, i, trg.size(), src.size()) * p;
in the surrounding loops, i ranges from 1 to src.size() inclusive and j
from 0 to trg.size() exclusive. Further up in the code, j+1 is used as
well, and I think the feature calculation assumes the same.This bug would bias it towards a flatter distribution I think, but I'm not
sure.—
Reply to this email directly or view it on GitHubhttps://github.com//issues/4
.
from fast_align.
You either pay for this with a slightly off-center prior either when j=0 or j=trg.size() - 1
I'm not sure I quite follow this. Right now when collecting counts the features used are
calculated using 0-based indexing, while the rest of the program uses 1-based indexing.
The diagonal is calculated using the same (1-based). When using j+1 in that bit of code, doesn't it
just fix it to do what the paper says? How does that put the prior off-center?
from fast_align.
Related Issues (20)
- [BUG] tot_len_ratio being inf when src.size() is zero
- Problem with large data HOT 5
- force_alignment with score HOT 1
- How can I reproduce the result reported in the paper ?
- Inference on new corpus by trained alignments HOT 7
- en-jap alignements HOT 2
- Issue when symmetrizing forward and reversed links HOT 1
- How to train this model in a new corpus? HOT 5
- Error happened: expected target length = source length * 0.934537 By train a large dataset HOT 1
- Setting up fast_align HOT 2
- Is it possible to hide stdout when aligning?
- Not able to train model for chinese HOT 1
- Implementing fast_align model in detail!!
- some questions
- force_align.py (TypeError: a bytes-like object is required, not 'str') HOT 3
- bash: ./fast_align: 没有那个文件或目录
- Alignments generated by force_align is different from the original alignment. HOT 2
- some confusions
- What does this Error message mean ? HOT 1
- Paper link in README is expired HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fast_align.