Code Monkey home page Code Monkey logo

Comments (6)

ckormanyos avatar ckormanyos commented on July 18, 2024 1

Hello @xamidi this is now fixed by #336, see change set b3f4aac

Please use either the command line switch when callinng the compiler:

-DWIDE_INTEGER_DISABLE_PRIVATE_CLASS_DATA_MEMBERS

or

#define WIDE_INTEGER_DISABLE_PRIVATE_CLASS_DATA_MEMBERS

above the inclusion of the uintwide_t.h header file.

from wide-integer.

ckormanyos avatar ckormanyos commented on July 18, 2024 1

Thank you for the quick fix. I switched to the original file already, and all seems good.

Great! Thank you @xamidi for raising this interesting issue. Glad it works.
If you encounter anything else or have future ideas, please feel free to stop by.

from wide-integer.

ckormanyos avatar ckormanyos commented on July 18, 2024

... tried to use math::wide_integer::uint256_t as a template parameter, but it failed with an error ...

... the existence of non-public data members

Thank you for your query. I must admit, I have never tried this exact kind of templatization. Please allow me to take a look at a few options regarding compatibility and get back to your query shortly.

I would not immediately want to make the private data members public, but we might consider doing this with a new, specific compiler switch.

Anyway, please allow me to investigate your query a bit. i'll get back with suggestions...

Kind regards, Chris

from wide-integer.

ckormanyos avatar ckormanyos commented on July 18, 2024

Proposed solution:

#define WIDE_INTEGER_DISABLE_PRIVATE_CLASS_DATA_MEMBERS

This optional macro can be used to disable uintwide_t's private data members and make them public. This allows the uintwide_t class to be used as a structured class object, such as is needed for constant-valued template parameters in the sense of C++20's constexpr-ness.

Making private data members public is unusual for some designs so the default value is WIDE_INTEGER_DISABLE_PRIVATE_CLASS_DATA_MEMBERS disabled and uintwide_t's data members remain private.

from wide-integer.

ckormanyos avatar ckormanyos commented on July 18, 2024

The repair is cycling in CI.

Cc: @xamidi

from wide-integer.

xamidi avatar xamidi commented on July 18, 2024

Thank you for the quick fix. I switched to the original file already, and all seems good. :)

from wide-integer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.