Code Monkey home page Code Monkey logo

Comments (5)

oleq avatar oleq commented on August 22, 2024 1

I would simply add the styles to <div id="editor"> to give it the same width and background as the editable of the actual editor. So when the editor loads, to the user, it would look like <div id="editor"> is being "boxed", transformed into the editor, which is acceptable.

from ckeditor5.github.io.

Reinmar avatar Reinmar commented on August 22, 2024

I've talked with @oleq about this recently. I think that that FOUC cannot be easily avoided by pulling the styles out of the JS file and moving them to the <head> because these styles base on classes which are added later. So either we add separate styles (independent from the editor, targeted at styling the content when the editor is not available) to that website's stylesheet or we just hide the content before editor loads. I don't like the latter – the former seems more correct to me.

from ckeditor5.github.io.

fredck avatar fredck commented on August 22, 2024

Small devil question... considering that this site is a demo of CKEditor, which comes in a script... does it make sense to have the script at the end of the page instead of "head". There is nothing else in the page for the user to contemplate, anyway ;)

from ckeditor5.github.io.

Reinmar avatar Reinmar commented on August 22, 2024

AFAIK this will also block rendering the rest of the website and loading the other files – IMO, it's better to show something than to show nothing for the entire time.

from ckeditor5.github.io.

fredck avatar fredck commented on August 22, 2024

Exactly... but that "something" is the problem... it's more like "whatever" and I feel that "nothing" is better, then.

Maybe we put the script element right before the editor contents then?

Or maybe move the Hotjar and Google Tag Manager scripts to the button as well and see what happens?

from ckeditor5.github.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.