Typing second underscore in a paragraph makes italic from the first one about github-writer HOT 7 CLOSED

Yup, upstream issue. Similar to ckeditor/ckeditor5#5862. And perhaps exactly this: ckeditor/ckeditor5#1239.

from github-writer.

That's certainly and issue with the auto-formatting feature and we must report it at CKEditor 5.

One could say that auto-formatting should be triggered only if the opening marker(_) is in a word boundary. It would not solve all cases, but it would help.

Auto-formatting can be undone, by pressing ctrl/cmd+z right after the formatting happens. It has its learnability issue, but it's hard to say if this will be seen as a bug or an enhancement.

from github-writer.

I would rather use the _ as an opening/closing for the auto-formatting only on the beginning/end of the word respectively. Underscore inside a word should be treated as a regular character.

This case is especially visible here on GH in inline code as it is not possible to format only a part of the code.

from github-writer.

The minimum thing to do would be to disable all automatic things happening inside code blocks and inline code. An even better solution would be to make the opening _ work only when used at the beginning of some word and closing _ only at the end of a word, but that's more tricky.

from github-writer.

and closing _ only at the end of a word

I think we're able to check only the start, because the end _, which triggers auto-formatting, happens when the user is typing and we don't know what will be typed next.

from github-writer.

I'm considering disabling auto-formatting for italics when typing underscore, for the time being. It is a character used way too often and having such feature seems to cause more harm that good.

WDYGT?

from github-writer.

I'm considering disabling auto-formatting for italics when typing underscore, for the time being. It is a character used way too often and having such feature seems to cause more harm that good.

I've decided to go a longer way and reviewed the auto-formatting totally. For more information, check out #105.

from github-writer.