Code Monkey home page Code Monkey logo

Comments (9)

creswick avatar creswick commented on September 26, 2024

From [email protected] on April 27, 2011 10:21:47

Here's a patch to replace commons-logging with slf4j.

This change would also require dropping commons-logging-1.1.1.jar and adding slf4j-api-1.6.1.jar and slf4j-log4j12-1.6.1.jar (alternatively you could use the slf4j-simple-1.6.1.jar (which just writes to stdout) and remove log4j from the project).

Sorry, could not figure out how to ignore the whitespace, either with eclipse or tortoise.

Attachment: use-slf4j.patch

from cjwizard.

creswick avatar creswick commented on September 26, 2024

From [email protected] on April 18, 2013 03:59:29

If you wanna remove external dependencies why not use the [ http://docs.oracle.com/javase/6/docs/technotes/guides/logging/ Java Loggin API]?

from cjwizard.

creswick avatar creswick commented on September 26, 2024

From [email protected] on October 02, 2013 00:31:54

Here is a patch to remove log4j and replace it with native java logging. Get in mind that I have not translate the log4j formats to JUL but if you think in adding this to the trunk I can make it.

Attachment: native-logging.patch

from cjwizard.

creswick avatar creswick commented on September 26, 2024

From [email protected] on December 28, 2013 10:23:06

"removing external dependencies" is not the point. the point is making your wizard a well-behaved component that application developers can drop in without causing difficulties. As a component developer you don't get to choose the logging framework, that's up to the application developer. You should use something like slf4j so that your component will use whatever logging framework the application it's added to uses.

from cjwizard.

PhoneixS avatar PhoneixS commented on September 26, 2024

I see your point.

In my specific project, we need that the resulting jar to be as little as it can so removing dependencies when possible is good. But is in my specific project.

from cjwizard.

PhoneixS avatar PhoneixS commented on September 26, 2024

For those who also need to remove it, I have created a branch in my fork (https://github.com/PhoneixS/cjwizard/tree/remove-log4j) that don't have this dependencies.

from cjwizard.

Petikoch avatar Petikoch commented on September 26, 2024

I agree on this one. It's better if a library has no dependencies at all...

For all Slf4J-Users out there like me... there's an easy workaround to get rid of this issue. Just add jcl-over-slf4j explicitly as dependency and remove the commons-logging and log4j dependencies.

For more details see http://www.slf4j.org/legacy.html.

from cjwizard.

creswick avatar creswick commented on September 26, 2024

I just tried switching to slf4j.

Since the test suite isn't that comprehensive, and I don't actually use this project any more it's difficult for me to tell if I actually solved the problem.

Could one of you folks take a look? The work is on this branch:

https://github.com/cjwizard/cjwizard/tree/feature/slf4j

Thanks!

from cjwizard.

Petikoch avatar Petikoch commented on September 26, 2024

@creswick

https://github.com/cjwizard/cjwizard/tree/feature/slf4j looks good!

+1

from cjwizard.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.