make it available from a Maven repo about cjwizard HOT 46 CLOSED

I think we should fix #3 first, so the apache logging isn't dragged along.

Switching to slf4j seems reasonable to me, but I haven't had time to dig through the patch from @nathan-hughes yet (https://code.google.com/p/cjwizard/issues/detail?id=3).

from cjwizard.

You don't need to change it, log4j is also in maven repositories. You only need to declare it as a dependency.

from cjwizard.

I think we should "play nice" with logging frameworks, as the initial reporter mentioned in #3. As is, anyone installing cjwizards will have multiple loggers running (most likely), which would be confusing.

from cjwizard.

This was the reason in #3 I have suggested the use of java logging. You don't add any dependency or logger because it is bundle in Java so other projects using the wizard will simply import the source and not need to worry about including other library for logging only the wizard.

from cjwizard.

I think that's a different concern, although I haven't used Java logging very much.

The benefit of slf4j is that it will use any of a number of actual logging backends, so if your application is using log4j, the wizard would also log to log4j, or if you were using java logging, it would log to that backend, and the log configuration would respect the same configuration used for the rest of the application.

from cjwizard.

Ohh, I see.

from cjwizard.

Only to keep it in mind, slf4j have a tool to help converting to its format. It can be found in http://www.slf4j.org/migrator.html.

from cjwizard.

Availability via Maven would be huge plus. I could support you in the transition phase and for testing purposes.

from cjwizard.

I forked this repo and without the log4j/commons-logging discussion, this project is ready for maven. I tested it against my own project.
Propably, you want to have a look at my branch/pull-request. It was very little work, so it could be merged easily without being dependent on #3.
Here is my pull-request: #29

from cjwizard.

Ok, thank you for your effort. When I have more time I will test it and merge to the trunk.

from cjwizard.

Great!

Thanks Philip.

@PhoneixS The pull request looks good to me -- I'd suggest merging it if you don't have objections. +1 for travis integration, too.

On Tue, Feb 17, 2015 at 3:45 AM, Javier Alfonso [email protected]
wrote:

Ok, thank you for your effort. When I have more time I will test it and
merge to the trunk.

—
Reply to this email directly or view it on GitHub
#14 (comment).

from cjwizard.

Gah, Github seems to be doing odd things with my comment edit. To be clear:

@PhoneixS The pull request looks good to me -- I'd suggest merging it if you don't have objections. +1 for travis integration, too.

from cjwizard.

Cool! I look into the maven publishing, too.

from cjwizard.

Done, I have merged it.

I think that @creswick must add the project to travis as is the one with enough privileges in github.com/creswick/cjwizard repository (read more about it in http://docs.travis-ci.com/user/getting-started/) so the official repository is checked instead of Guerda's repository.

Also to be noted is that the project use maven but it isn't "mavenized" as the layout is the old layout. In maven normally you have the folders src/main/java/com/... instead of only src/com/... but it's a step on the right direction. But before publishing it I think we should change it to have the standard layout.

from cjwizard.

Thanks for the merge!
Regarding the standard layout for Maven projects: I wanted to create a running project which builds in Travis successfully before refactoring the source folder layout.
I will do this in a later pull request.
Regarding Travis CI: You are correct, the Travis webhook must be activated by the repo owner. Then the README.md must be updated. I cannot do this via a pull request.

from cjwizard.

Here's the PR: #30

from cjwizard.

Here are some basic information how to publish to OSSRH and then to Maven Central: http://central.sonatype.org/pages/ossrh-guide.html

Some of the requirements for the deployment:

• correct information (GAV)
• developer information including urls
• scm information
• GPG signed artifacts
• correct artifact naming
• JIRA ticket for Maven central

from cjwizard.

Merged the PR, and updated the travis url to point to my travis account's build (which I also just enabled).

I'm not sure when I can work through the OSSRH details; probably not this week, but I'll try to do so as soon as possible (possibly this weekend; the 7-8th). If there are infrastructure details, such as generating signed releases, that you (@guerda or @PhoneixS) could help with, that'd be great!

from cjwizard.

Here's the OSSRH ticket:

https://issues.sonatype.org/browse/OSSRH-14241

from cjwizard.

@creswick I'm currently working on the correct format for the release plugin, so yet another PR will come soon. You just need a GPG key pair to perform the task afterwards.

from cjwizard.

#31 contains GPG signing, License information, sources jar inclusion and developer information. Should be all to release on OSSRH. Have fun!

from cjwizard.

Thanks!

So, unfortunately, my domain registration lapsed, and I don't have ciscavate.org anymore. It looks like I might be able to get it back, but we may need to change the package/group prefix before the package will be accepted.

from cjwizard.

It is a big change but I think that it is necessary. And maybe is good to make an official organization in github (can be also called cjwizard) so you can use com.github.cjwizard as package an translate the "oficial" repository to that organization.

from cjwizard.

The github organization sounds good to me. I've created one and forked the repo over there.

Does anyone know if it's possible to move the tickets? https://github.com/cjwizard/cjwizard

from cjwizard.

@creswick you don't need to fork it, you must transfer the owner of the repository to the group. This way issues and other things are also transferred. You can read more about it in https://help.github.com/articles/transferring-a-repository/

I have deleted the fork so you can transfer it without conflict.

from cjwizard.

I have deleted the fork so you can transfer it without conflict.

Thanks!

from cjwizard.

I created a branch for the refactor, switching the groupId to 'com.github.cjwizard', updating the metadata in the pom.xml, and changing the 'org.ciscavate' prefix to 'com.github.cjwizard' in the packages.

The branch is here: https://github.com/cjwizard/cjwizard/tree/githubGroupId

Could you folks (@PhoneixS and @guerda) try that branch and let me know if I broke anything? The tests pass, but I'm not confident that they cover much...

I've bumped the version to 0.22, also, but that may need to go higher (1.0?) to indicate the breaking change.

from cjwizard.

Yes I also think that is better to increase to 1 because it had changed the layout and many other things.

from cjwizard.

Also you need to change the Travis CI repository so it point to the correct repository (although it is running now by redirect of github).

from cjwizard.

Bumped version to 1.0.0-snapshot.

I think I'm waiting on Travis to see the cjwizard org (I did just authorize access) before I can update / create a new travis job.

from cjwizard.

@creswick For me, it looks fine. We should definitely work on the unit tests, but that's a second step, imho. I think you can merge it to master and publish a new release 1.0.

from cjwizard.

As it is already merged I've just updated the Travis CI repository to the new organization repository (https://travis-ci.org/cjwizard/cjwizard).

from cjwizard.

Any news on this?

from cjwizard.

I had some issues with the maven package commands, and may need help getting that straightened out, but I haven't had time to sit down and write up a ticket.

from cjwizard.

Hmmm... this is still open :-(

It seems that you had some issues to bring it to "maven central"? As workaround... publishing it to Bintray (a competitor repo) is IMO simpler... Check out e.g. https://blog.bintray.com/2015/09/17/publishing-your-maven-project-to-bintray/

Best regards,
Peti

from cjwizard.

@Petikoch I had some issues with the maven process; rooted in my general lack of time to dedicate to this project :(

I'm happy to help transition if anyone else is interested and willing to take over as maintainer!

from cjwizard.

@Petikoch Bintray doesn't seem to be working for me, unfortunately. Any suggestions on this failure?

[ERROR] Failed to execute goal org.sonatype.plugins:nexus-staging-maven-plugin:1.6.3:deploy (injected-nexus-deploy) on project cjwizard:
Failed to deploy artifacts: Could not transfer artifact com.github.cjwizard:cjwizard:jar.asc:sources:1.0.3-20160810.225152-1 from/to bintray-repo-cjwizard (https://api.bintray.com/maven/creswick/CJWizard/cjwizard/;publish=1): Failed to transfer file: 
https://api.bintray.com/maven/creswick/CJWizard/cjwizard/;publish=1/com/github/cjwizard/cjwizard/1.0.3-SNAPSHOT/cjwizard-1.0.3-20160810.225152-1-sources.jar.asc.
Return code is: 400,
ReasonPhrase: Bad Request. -> [Help 1]

from cjwizard.

@creswick , I don't know what's the source of the problem above.

Maybe there is an issue with the repo ID? According to the Bintray UserManual https://bintray.com/docs/usermanual/formats/formats_mavenrepositories.html#anchorMavenDeploy it has the form bintray-[YOUR_USERNAME]-[REPOSITORY_NAME]

Therefore the section in the pom.xml should probably look like

<distributionManagement>
  <repository>
    <id>bintray-creswick-CJWizard</id>
    <url>https://api.bintray.com/maven/creswick/CJWizard/cjwizard/;publish=1</url>
  </repository>
</distributionManagement>

I hope this helps.

Best regards,
Peti

from cjwizard.

@creswick

After the sucessful publishing to Bintray, you can manually add your package to "JCenter" (https://bintray.com/bintray/jcenter). Bintray "JCenter" is something like maven central.

from cjwizard.

@Petikoch Thanks - the repository ID is documented as an arbitrary string; it just needs to match the corresponding authentication section in my Maven settings.xml (which is obviously not published).

I did change that, and it may have helped. The other thing that I didn't realize is that you can't upload SNAPSHOT versions, so changing to 1.0.4 seems to have worked (although the deploy command did fail...)

Could you try this out and let me know if it worked?

Here's the bintray release url:

https://bintray.com/creswick/CJWizard/cjwizard/1.0.4

from cjwizard.

@creswick , can you add it to jcenter? https://bintray.com/bintray/jcenter ("Include my package")

Usually people use either maven-central or jcenter or both.

Congrats for the release!

Best regards,
Peti

from cjwizard.

That should be underway now... I've had a number of failures with mvn
deploy, but I think that finally worked (on v. 1.0.5) Hopefully it'll be
transitioned to JCenter soon. (I just filed another request.)

On Fri, Aug 12, 2016 at 4:49 AM Peti Koch [email protected] wrote:

@creswick https://github.com/creswick , can you add it to jcenter?
https://bintray.com/bintray/jcenter ("Include my package")

Usually people use either maven-central or jcenter or both.

Congrats for the release!

Best regards,
Peti

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#14 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPusJHXRIbRniJZE3gWI4rjZjIxl3i5ks5qfF3YgaJpZM4Cng3i
.

from cjwizard.

Hi @creswick,

congrats, it's in Bintray's jcenter!

Best regards,
Peti

from cjwizard.

I think this issue could be closed now...

from cjwizard.

Closing;

For reference: CJWizard is up on JCenter here: https://bintray.com/creswick/CJWizard/cjwizard

from cjwizard.

For reference: It's now here: https://bintray.com/cjwizard/CJWizard/cjwizard

from cjwizard.