Approving data attribute of type 'array' gets written back with added slashes about approval HOT 6 CLOSED

@gerb-ster I can't recall but was this related to the #46 ?

from approval.

No, this is something else I'm afraid.

It has to do with this line:

The function json_encode is called to json encode the dirty attributes. But if one of those attributes is of the type 'array' it gets double json encoded.

After approval the new_data is converted back to an array on this line:

and that way you will end up with a json string instead of an array.

I'll open an bugfix-branche and add a test to expose this issue.

from approval.

I've added a test which shows the issue

https://github.com/gerb-ster/approval/tree/bugfix_array-attributes

from approval.

Hmm,

I had a quick glance as I had some time. I thought it might be to do with the fact that I am casting new_data and original_data in the Approval model already, as well as encoding it elsewhere, so thought that might be why it is double encoding, but that doesn't seem to be the case as the test still fails 🤔

I can't seem to spot a solution just yet, so if you're able to help out further that'd be great as it does seem like something that could be an issue later, I just haven't had the time lately to focus on Open Source stuff.

Thanks!

from approval.

@cjmellor Sure, I'll have a look later today!

from approval.

Closed by #47

from approval.