Code Monkey home page Code Monkey logo

Comments (7)

saracarl avatar saracarl commented on June 17, 2024

the concern is when the Omeka rendering changes for a document that already had annotations -- what happens to the annotations? Do they become unmoored because the anchor target selector no longer refers to a valid region of the DOM.

Use the above example to test this (if possible)

from mashbill.

saracarl avatar saracarl commented on June 17, 2024

first case was just missing a name, the 2nd case was a missing column in the Omeka rendere.

from mashbill.

saracarl avatar saracarl commented on June 17, 2024

@PatrickALewis please make sure that both of these docs "pre" fixing have annotations on them that we can test with.

from mashbill.

PatrickALewis avatar PatrickALewis commented on June 17, 2024

They do.

I looked into http://discovery.civilwargovernors.org/document/KYR-0362-001-0001 more. The Omeka style sheet issue went deeper than we thought. Because it can't figure out how to render the material between multi-columns (committee names and T. W. Owings), it just stripped those out of the HTML entirely.

Could page notes be a temporary solution to hang an annotation off of text that isn't present?

from mashbill.

JeffDycus avatar JeffDycus commented on June 17, 2024

I've will be continuing to work with the stylesheet to get these documents to render correctly in Omeka, but this also leads to a larger question about documents changing in Omeka. I'm going to create a new issue for that discussion.

from mashbill.

saracarl avatar saracarl commented on June 17, 2024

for testing can also work with a "private" document in Omeka and change it/update it to test how easy it is to identify an annotation if the document changed after it was annotated.

from mashbill.

benwbrum avatar benwbrum commented on June 17, 2024

I think this may have #87 as a side effect, since the annotation target selector contains paragraph tags which are no longer present in Omeka. We can handle this in Mashbill through error handling, once we understand what changed.

from mashbill.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.