Code Monkey home page Code Monkey logo

Comments (6)

ciur avatar ciur commented on May 18, 2024

You are right, OCR_BINARY setting is ignored.
I will fix this problem.

from papermerge.

ciur avatar ciur commented on May 18, 2024

Hi @mtonnie

I pushed couple of commits:

Also notice that instead of OCR_BINARY was renamed to BINARY_OCR. This is to be consistent with rest of BINARY_ settings:

  • BINARY_FILE default value is "/usr/bin/file"
  • BINARY_CONVERT default value is "/usr/bin/convert"
  • BINARY_PDFTOPPM default value is "/usr/bin/pdftoppm"
  • BINARY_PDFINFO default value is "/usr/bin/pdfinfo"
  • BINARY_IDENTIFY default value is "/usr/bin/identify"
  • BINARY_OCR default value is "/usr/bin/tesseract"
  • BINARY_PDFTK default value is "/usr/bin/pdftk"

All above settings can be added to papermerge.conf.py to modify path of respective executable.

Also notice that mglib version was incremented.
This code is very fresh (I just pushed). According to my couple of tests it works pretty well. Anyway, tomorrow I will update documention and perform couple of more tests.

To be continued...

from papermerge.

mtonnie avatar mtonnie commented on May 18, 2024

Hi @ciur,

I guess the checks in core/checks.py should also take into account the variables.
If not these checks may fail when the location of the binary isn't inculded in PATH enironment variable.

What do you think?

from papermerge.

ciur avatar ciur commented on May 18, 2024

Hi @mtonnie ,

correct! I absolutely agree. Here is the fix.

Documentation update.

@mtonnie thank you for your great feedback!
If the case above changes solved your problem with hardcoded binary paths - please close this ticket/issue.

Thank you again!

from papermerge.

mtonnie avatar mtonnie commented on May 18, 2024

Thanks a lot, looks good so far.
I'll test it with synlology package soon, I have focus on installation wizard the last few days.

from papermerge.

ciur avatar ciur commented on May 18, 2024

@mtonnie, yes I saw your packaging progress.I pinned that issue - as I consider it very important one. Awesome work! Thank you!

from papermerge.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.