Code Monkey home page Code Monkey logo

Comments (10)

timwis avatar timwis commented on September 24, 2024

Now that I've actually read that doc page, it looks perfect!

from soda-carto.

andrewbt avatar andrewbt commented on September 24, 2024

from soda-carto.

timwis avatar timwis commented on September 24, 2024

This is almost working:

resources:
  Resources:
    ProxyResource:
      Type: AWS::ApiGateway::Resource
      Properties:
        ParentId:
          Fn::GetAtt:
            - ApiGatewayRestApi # our default Rest API logical ID
            - RootResourceId
        PathPart: carto # the endpoint in your API that is set as proxy
        RestApiId:
          Ref: ApiGatewayRestApi
    ProxyMethod:
      Type: AWS::ApiGateway::Method
      Properties:
        ResourceId:
          Ref: ProxyResource
        RestApiId:
          Ref: ApiGatewayRestApi
        AuthorizationType: NONE
        HttpMethod: GET # the method of your proxy. Is it GET or POST or ... ?
        MethodResponses:
          - StatusCode: 200
        Integration:
          IntegrationHttpMethod: GET
          Type: HTTP
          Uri: https://phl.carto.com/api/v2/sql # the URL you want to set a proxy to
          IntegrationResponses:
            - StatusCode: 200

The problem appears to be that API Gateway doesn't pass querystrings along by default, and it looks like the only way to enable them is to explicitly activate each one. Fortunately, with carto, we can activate q, format, and filename, though what if carto adds another parameter? And perhaps there are others that simply aren't in the sql api docs? Definitely not ideal :-/

Need someone familiar with API Gateway / cloudformation to weigh in. I've asked in freenode ##aws and the og-aws slack.

EDIT: Also, I think that ideally it would be data.phila.gov/api/v2/sql?q=xxxx for the URL schema, rather than /carto. Not super firm on it but it seems to make sense to me. Note that one of the socrata url structures is /api/views/.... but that shouldn't matter.

EDIT2: Apparently you can make the resource pathpart {proxy+} to use it like a "greedy parameter" and then use {proxy} in the method uri, like https://phl.carto.com/{proxy}. This may include querystrings. I haven't been able to get it to work. In particular, I was having trouble making the path something like /carto/{proxy+} or /api/v2/{proxy+}.

from soda-carto.

timwis avatar timwis commented on September 24, 2024

@andrewbt can you post the screenshots of the 3 configuration forms you got working when you get a chance? I can try to translate into cloudformation code this weekend.

from soda-carto.

timwis avatar timwis commented on September 24, 2024

Posted for help

from soda-carto.

andrewbt avatar andrewbt commented on September 24, 2024

Reposting screenshots from #37 :

Testable here: https://zsp6egcjhf.execute-api.us-east-1.amazonaws.com/dev/carto/v2/sql?q=select * from indego_stations where ST_DWITHIN(the_geom::geography, ST_GeographyFromText('POINT(-75.1636 39.9524)'),500)

Screenshots:
screen shot 2017-02-23 at 12 13 02 pm
screen shot 2017-02-23 at 12 13 33 pm
screen shot 2017-02-23 at 12 13 57 pm
screen shot 2017-02-23 at 12 16 07 pm

from soda-carto.

andrewbt avatar andrewbt commented on September 24, 2024

API Gateway allows you to “export” an API (under Stages) as a Swagger YAML or JSON document. One of the options for creating an API is through importing a Swagger document.

If we can’t get serverless.yaml to work with the HTTP-proxy integration and other options we need there for the pass-through API, Swagger seems like a good alternative and will still let us keep “deployment in code” rather than through the AWS console UI.

from soda-carto.

timwis avatar timwis commented on September 24, 2024

https://blog.jayway.com/2016/09/18/introduction-swagger-cloudformation-api-gateway/ 👯

from soda-carto.

timwis avatar timwis commented on September 24, 2024

giphy

We bloody cracked it!!

I got swagger to work, but it ended up overwriting all the serverless functions. But then I noticed that the swagger itself was basically cloudformation. So that told me what pieces were missing from the original cloudformation. And it's working! :D

https://67qq7fn418.execute-api.us-east-1.amazonaws.com/dev/carto/api/v2/sql?q=select%20*%20from%20pol_incidents_part1_part2%20limit%2010

from soda-carto.

andrewbt avatar andrewbt commented on September 24, 2024

from soda-carto.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.