Comments (9)
@christmart can you provide some information on how OpenSSL is packaged for s390x? Failures here could also be due to the lack of EC support being compiled in.
We'll work on a way to get more detailed errors reported from OpenSSL otherwise.
from cjose.
@linuxwolf the errors occur in a build of 0.4.1 which was released before reformatting; so jws.c:536 refers to this line:
Line 536 in 67eba48
from cjose.
@zandbelt @christmart there are only three ways for cjose_base64url_encode to fail:
- memory errors
- NULL or 0 input
- NULL outputs
The jws.c code definitely prevents # 3 from happening, which leaves either memory errors or bad inputs. I think I recall some versions of OpenSSL with EC features compiled out would not return errors, but might not return values either.
from cjose.
from cjose.
from cjose.
The attachement of the previous message is missing.
I got the following hint from Aurelien Jarno [email protected]:
Looking at the failures, it seems to fails on all 64-bit big-endian
architectures (ppc64, s390x, sparc64). Looking at the code, there is
an issue with at least this part of the code from jws.c:
if (RSA_sign(digest_alg, jws->dig, jws->dig_len, jws->sig, (unsigned int *)&jws->sig_len, (RSA *)jwk->keydata) != 1)
You can't cast a pointer to a pointer of different size.
from cjose.
Thanks for the hint. I don't see anything in the openssl configuration items that point to a particular problem. That line is certainly a bug that should be addressed, but I have no way to confirm it's the cause of this issue.
from cjose.
from cjose.
The patch is working and also fixes the problem with the failing test after building on s390x, sparc64 and ppc64.
from cjose.
Related Issues (20)
- Unusual IV for AES_CBC HOT 2
- is this repo alive and maintained? HOT 1
- Failed to build 32 bit cjose
- Add support for ES256K
- Maintenance status of this project
- Is it supported input the AAD when call cjose_jwe_encrypt function?
- struct _key_fntable_int incompatible with memory leak detectors HOT 3
- memory allocation error HOT 1
- Visual C++ source incompatibility HOT 3
- Can cjose be installed successfully on solaris 11.3?
- RSA PEM format HOT 1
- Does support "alg": "RSA-OAEP-256"?
- CPU usage for routine cjose_jws_verify HOT 1
- Support building with OpenSSL 3.0 HOT 4
- external maintenance fork 0.6.2.x HOT 1
- Does the project support RSA-OAEP-256 algorithm?
- The asserts in base64.c can crash the application using the lib
- SECURITY VULNERABILITY: incorrect Authentication Tag length usage in AES GCM decryption HOT 1
- machine ... not recognized with --with-jansson HOT 1
- clang-format status
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cjose.