Comments (2)
Documenting the approach I used on #176:
- I created a new function in the Utils file
ReportDetails
. Because it's in the Utils file, when implementing this change for other baselines, there won't be any need to implement this again. - For each control:
a. Determine an appropriateSettingDescription
for the setting in question
b. Determine if theLastEvent.NewValue
value is user-friendly; if not, create aGetFriendlyValuex_x
function that translates the values to user-friendly strings (see #176 for examples)
c. Refactor theNonCompliantOUsx_x
rule so that it includes both "Name" and "Value" keys
d. Change theReportDetailsOUs
call toReportDetails
(include the SettingDescription from step a)
e. Test and ensure it works as expected
f. Update the unit tests to reflect the change
Scenarios that aren't covered by the above workflow:
- Handling settings that aren't controlled at the OU level
- Controls that depend on multiple settings
from scubagoggles.
See #204 for how this would look post group bug fix.
from scubagoggles.
Related Issues (20)
- Remove Version Numbers from Control IDs in the Rego
- Split up the main README HOT 1
- Fix the sample report generation script to better parse nested JSON
- Include Group Reference URL in ScubaResults.json HOT 1
- Clarify GWS.DRIVEDOCS.3.1v0.2 HOT 2
- Rename the baseline markdown files HOT 1
- Create Policy Group 16 (Additional Google Services) Section in Common Controls HOT 2
- Moving COMMONCONTROLS.11.2v0.2 into Policy Group 10 HOT 2
- Meet settings not being checked at the group level
- Determine the minimum supported Python version HOT 5
- Numpy 2.0 release breaks Pandas functionality HOT 2
- DefaultSafe variable is incorrect in many cases HOT 1
- Python Unit Testing for GWS
- Review newly added GWS Assured controls
- Create a GitHub Action to deploy baselines to cisa.gov Drupal site
- Failed to build installable wheels for some pyproject.toml HOT 1
- GMAIL.19.2 and GMAIL.19.3 are not implemented in the Rego
- Check for the correct baseline version in generated reports when running smoke tests
- Update run_smoke_test.yml with ability to intake user inputs from workflow dispatch
- Update documentation on how to run smoke tests HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scubagoggles.