Code Monkey home page Code Monkey logo

Comments (2)

adhilto avatar adhilto commented on August 25, 2024

Documenting the approach I used on #176:

  1. I created a new function in the Utils file ReportDetails. Because it's in the Utils file, when implementing this change for other baselines, there won't be any need to implement this again.
  2. For each control:
    a. Determine an appropriate SettingDescription for the setting in question
    b. Determine if the LastEvent.NewValue value is user-friendly; if not, create a GetFriendlyValuex_x function that translates the values to user-friendly strings (see #176 for examples)
    c. Refactor the NonCompliantOUsx_x rule so that it includes both "Name" and "Value" keys
    d. Change the ReportDetailsOUs call to ReportDetails (include the SettingDescription from step a)
    e. Test and ensure it works as expected
    f. Update the unit tests to reflect the change

Scenarios that aren't covered by the above workflow:

  • Handling settings that aren't controlled at the OU level
  • Controls that depend on multiple settings

from scubagoggles.

adhilto avatar adhilto commented on August 25, 2024

See #204 for how this would look post group bug fix.

from scubagoggles.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.