CS.jl disconnecting pairs while CS 4.05 is not about circuitscape.jl HOT 17 CLOSED

Hi @rmarrotte, could you please paste the output of the following code on the Julia terminal:

Pkg.status("Circuitscape")

Also, is there a way you could share your input so I can check? Thank you.

from circuitscape.jl.

Pkg.status("Circuitscape")
Circuitscape 5.0.0+ master
https://www.dropbox.com/sh/jvqkt0zcwf0yll1/AAAd8YB9XZy59WIrG8rahle4a?dl=0

from circuitscape.jl.

Thanks, @rmarrotte. According to logs, it seems to take a fewer pairs (86736) instead of the right number of pairs(268278). This seems to happen even as I disable the include_pairs option. Odd. I'll figure it out and let you know ASAP.

from circuitscape.jl.

Yes, @ranjanan I was wondering whether there was a maximum number of nodes or some kind of maximum resistance threshold or something. Also, I was thinking it could be that some nodes are very close to each other, but there isn't this pattern in the data at all.

from circuitscape.jl.

No, I don't have either of those thresholds. I think I just made a mistake counting the number of pairs to solve. I'm investigating it right now.

from circuitscape.jl.

@rmarrotte could you run the following commands at the Julia prompt:

Pkg.checkout("Circuitscape")
Pkg.checkout("Circuitscape", "pt_calc")

restart Julia and then see if you're getting the right answer? Just checking out a hunch.

from circuitscape.jl.

@ranjanan No update was available, same results.

from circuitscape.jl.

@rmarrotte I'm sorry, by

No update was available

do you mean you weren't able to checkout the branch? Or were you able to check out the branch but it didn't fix the issue? Did you restart Julia before trying?

from circuitscape.jl.

@ranjanan It checked it out and found nothing new for both. Restarted Julia before I did this. Ran CS just in case, but nothing new.

from circuitscape.jl.

Hi @rmarrotte I pushed one more commit to the same branch. Could you do Pkg.checkout("Circuitscape", "pt_calc") again and check please? Thanks.

from circuitscape.jl.

Nope, nothing new to update or install

from circuitscape.jl.

Okay then. I'm sorry about this. I will run this privately and come up with a fix.

from circuitscape.jl.

Hi Robby, I'm really sorry, but I'm having some trouble because your example has a really high number of pairs to solve which makes it hard to debug this. Is there a slightly smaller problem that you have where you can reproduce this behaviour?

from circuitscape.jl.

@rmarrotte ^

from circuitscape.jl.

@ranjanan Can we run connected components on the input and see if we are doing that correctly?

from circuitscape.jl.

@ranjanan Not really. Do you think it crashed because of 1 specific pair? Like I indicated a while back, there are some pairs that are right on top of each other within the same pixel. I think CS has some way of dealing with this by setting the effective resistance to 0 or -700.

from circuitscape.jl.

@rmarrotte #167 also fixes this. Is there a smaller test you can run to confirm this?

from circuitscape.jl.