Comments (2)
Love the idea! This should be simple to merge. I think the feature has a few more requirements:
- I don't see where the global flag
--http_timeout
is setup? Did you do that part? Also, from the user's point of view, I don't think it matters that this is HTTP in the flag. Let's just call it--timeout
and add the HTTP part to the inline help. HTTP_TIMEOUT
seems like too generic a term. Can we add a prefix to "namespace" the environment variable?CIRCLECI_CLI_TIMEOUT=30s
should do fine.- There is another HTTP client in the CLI, used for exchanging with the GraphQL API (mostly for Orbs). Can we make sure the timeout is applied to both clients? (source)
Finally, I'd like to see at least one test in there. You can add an integration test to config/commands_test.go
, creating a new mock server with httptest.NewServer
that takes longer time to respond than the timeout.
Let me know if any of this is unclear, I'll be glad to help.
from circleci-cli.
@or-shachar cli released you can define http timeout now
from circleci-cli.
Related Issues (20)
- Change `.circleci` home directory location with an Environment variable HOT 3
- [Feature Request] Add number of Active tasks in "runner instance list" command
- Wrong version of circleci inside local execution env HOT 2
- CircleCI Orb Init Error Misleading HOT 2
- Unable to start job with private images using `circleci local execute`
- docker: Error response from daemon: invalid mount config for type "bind": bind source path does not exist: /tmp/3966974312_circleci_config.yml. HOT 1
- IN1-GOLANG-GITHUBCOMCLOUDFLARECIRCLPKEKYBERINTERNALCOMMON-6150686 - github.com/cloudflare/circl
- CircleCI CLI policy test command missing timestamp in JUnit output HOT 2
- `circleci local execute` does not work with Docker for Desktop on OSX HOT 1
- Json unmarshall error HOT 2
- Error: Unable to validate config HOT 4
- Clarify `orb validate` and `config validate` scope of validation HOT 1
- Infinite install bug HOT 2
- Provide mac arm64 release asset
- unable to execute local job on mac m1 pro HOT 2
- invalid character 'I' looking for beginning of value HOT 13
- ` local execute build` command fails when sidecar is present and using the latest docker version HOT 1
- circleci config pack command is not working with latest version (v0.1.28363) HOT 2
- Orb validation fails HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from circleci-cli.