Code Monkey home page Code Monkey logo

Comments (2)

loderunner avatar loderunner commented on August 29, 2024

Love the idea! This should be simple to merge. I think the feature has a few more requirements:

  1. I don't see where the global flag --http_timeout is setup? Did you do that part? Also, from the user's point of view, I don't think it matters that this is HTTP in the flag. Let's just call it --timeout and add the HTTP part to the inline help.
  2. HTTP_TIMEOUT seems like too generic a term. Can we add a prefix to "namespace" the environment variable? CIRCLECI_CLI_TIMEOUT=30s should do fine.
  3. There is another HTTP client in the CLI, used for exchanging with the GraphQL API (mostly for Orbs). Can we make sure the timeout is applied to both clients? (source)

Finally, I'd like to see at least one test in there. You can add an integration test to config/commands_test.go, creating a new mock server with httptest.NewServer that takes longer time to respond than the timeout.

Let me know if any of this is unclear, I'll be glad to help.

from circleci-cli.

abdelDriowya avatar abdelDriowya commented on August 29, 2024

@or-shachar cli released you can define http timeout now

from circleci-cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.