When setting the profile-name property, ecr-login fails. about aws-ecr-orb HOT 9 CLOSED

from aws-ecr-orb.

@eddiewebb We actually experimented with this and we can in fact pass --profile. The command is not specific to ECR get-login, but rather is picked up by the AWS CLI: https://docs.aws.amazon.com/cli/latest/reference/index.html#cli-aws

For clarity, we invoked the ECR get-login command from the build and push image step referenced here: https://github.com/CircleCI-Public/aws-ecr-orb/blob/master/src/commands/ecr-login.yml#L16
aws ecr get-login --no-include-email --profile our_profile

Let us know if you would like us to open up a PR.

from aws-ecr-orb.

thanks ! @jeffnappi i don't think we're currently integration-testing the orb with alternate profile names, let me set that up & that should help resolve this

from aws-ecr-orb.

@jeffnappi can you be more specific about where the failure occurs ? feel free to link me to a job, so i can take a look

if the failure is towards the beginning, the bug may be in our AWS CLI orb, not this one—otherwise, if it occurs later on, it's probably an issue with this orb

from aws-ecr-orb.

hmmmm, i'm not able to reproduce @jeffnappi https://circleci.com/gh/CircleCI-Public/aws-ecr-orb/224

from aws-ecr-orb.

@iynere we saw the same issue where failure occurs if profile-name is set. This occurs when trying to authenticate with ecr using get-login, I believe because the profile isn't set during this step.
I believe the issue is during this: LOGIN_COMMAND=$(aws ecr get-login --no-include-email --region $AWS_REGION)

from aws-ecr-orb.

@hollyhutson - thanks for the additional info, but the ECR login command uses this AWS command which does not support profiles - https://docs.aws.amazon.com/cli/latest/reference/ecr/get-login.html

Profile is specified at the time AWS CLI is configured by the underlying AWS orb. https://github.com/CircleCI-Public/aws-ecr-orb/blob/master/src/commands/build-and-push-image.yml#L127

@jeffnappi / @hollyhutson - please include a sample config that sees this issue for us to diagnose further. I'll mark this issue needing more details.

from aws-ecr-orb.

Thank you @sparta-developers - that makes good sense.

we would love a PR, I see 2 paths, though you ,might see others

1. add profile as specific parameter. This follows an established convention and addresses immediate need.
2. add a generic arguments to the command that could include --profule or other things.

#2 is more future proof but deviates from known patten, so #1 still feels like a good path.

from aws-ecr-orb.

@sparta-developers Thank you for your contribution on this issue! We have just released circleci/[email protected] based on your PR and hence will be closing this issue, and would encourage anyone who was following this issue to try out the new version!

from aws-ecr-orb.