Add parameter to allow docker layer caching about aws-ecr-orb HOT 8 CLOSED

found a way to do this using the machine executor:

executors:
  build-executor:
    machine:
      docker_layer_caching: true

from aws-ecr-orb.

@dankarpinski is there a reason you closed your PR back in October? we just merged a similar change to our Docker orb:

CircleCI-Public/docker-orb#44

feel free to re-open or open a new PR and we will get it merged ASAP—thanks !

from aws-ecr-orb.

But how do you use DLC with a custom docker executor as your original question stated? e.g., if my config.yml file looks something like this:

version: 2.1
orbs:
  aws-ecr: circleci/[email protected]
  aws-ecs: circleci/[email protected]
executors:
  ubuntu-lfs:
    docker:
      - image: "${AWS_ECR_ACCOUNT_URL}/circle-executor:latest"
workflows:
  build-and-deploy:
    jobs:
      - aws-ecr/build-and-push-image:
          executor: ubuntu-lfs
          setup-remote-docker: true
... SNIP ...                       

The only argument that setup-remote-docker accepts is a Boolean (true in this case), correct? and the docker executor type doesn't have a parameter for enabling DLC?

from aws-ecr-orb.

Luckily wasn't necessary for my needs. It isn't possible now with a custom docker executor.

from aws-ecr-orb.

@dankarpinski I have the same question as @iynere

I'd appreciate it if the PR could be merged!

from aws-ecr-orb.

Re-opened as a few people have mentioned demand. @iynere could you merge?

from aws-ecr-orb.

@dankarpinski @iynere I created a new PR which also conforms with the naming convention. PR #116

from aws-ecr-orb.

Resolved in #116. Thank you.

from aws-ecr-orb.