Comments (8)
found a way to do this using the machine executor:
executors:
build-executor:
machine:
docker_layer_caching: true
from aws-ecr-orb.
@dankarpinski is there a reason you closed your PR back in October? we just merged a similar change to our Docker orb:
feel free to re-open or open a new PR and we will get it merged ASAP—thanks !
from aws-ecr-orb.
But how do you use DLC with a custom docker executor as your original question stated? e.g., if my config.yml file looks something like this:
version: 2.1
orbs:
aws-ecr: circleci/[email protected]
aws-ecs: circleci/[email protected]
executors:
ubuntu-lfs:
docker:
- image: "${AWS_ECR_ACCOUNT_URL}/circle-executor:latest"
workflows:
build-and-deploy:
jobs:
- aws-ecr/build-and-push-image:
executor: ubuntu-lfs
setup-remote-docker: true
... SNIP ...
The only argument that setup-remote-docker
accepts is a Boolean (true
in this case), correct? and the docker
executor type doesn't have a parameter for enabling DLC?
from aws-ecr-orb.
Luckily wasn't necessary for my needs. It isn't possible now with a custom docker executor.
from aws-ecr-orb.
@dankarpinski I have the same question as @iynere
I'd appreciate it if the PR could be merged!
from aws-ecr-orb.
Re-opened as a few people have mentioned demand. @iynere could you merge?
from aws-ecr-orb.
@dankarpinski @iynere I created a new PR which also conforms with the naming convention. PR #116
from aws-ecr-orb.
Resolved in #116. Thank you.
from aws-ecr-orb.
Related Issues (20)
- Error when upgrading to the aws-cli orb 4.1.2 HOT 2
- AWS ECR Credential Helper HOT 1
- Documentation inconsistency for circleci/[email protected] HOT 2
- Only the first --build-arg is passed to Docker build in v9.0.2 HOT 2
- Image indexes are pushed even when only one platform is specified HOT 10
- Expressions no longer evaluated? HOT 1
- Similar bug to https://github.com/CircleCI-Public/aws-ecs-orb/issues/206 HOT 2
- Image created is of type Image Index HOT 3
- All image builds broken until new release occurs HOT 9
- Cannot login to multiple ECRs with version 9.0.3 HOT 1
- `no basic auth credentials` on push_image step HOT 4
- E: The repository 'https://apt.kubernetes.io kubernetes-xenial Release' does not have a Release file. HOT 2
- Regression: cannot use AWS credentials in Dockerfile HOT 1
- Allow accessing registry of different account (--registry-id)
- Error when running `aws-ecr/build-image` on Alpine HOT 1
- Bugfix: PATH parameter does not override BUILD_PATH parameter as docs suggest
- build_and_push_image does not take in account the platform correctly HOT 1
- ECR login succeeds, but push fails with HEAD request 401 unauthorized HOT 11
- build to local and for one platform only and do not push image
- Error when providing multiple comma-separated platforms
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aws-ecr-orb.