Code Monkey home page Code Monkey logo

Comments (4)

sparta-developers avatar sparta-developers commented on September 3, 2024

We are also experiencing this. We are on version 6.6.0

docker_tag_args=""
IFS="," read -ra DOCKER_TAGS <<< "latest,${CIRCLE_SHA1}"
for tag in "${DOCKER_TAGS[@]}"; do
  docker_tag_args="$docker_tag_args -t $AWS_ECR_URL/${AWS_ECR_REPO}:$tag"
done
docker build \
  -f Dockerfile \
  $docker_tag_args \
  /home/circleci/project/half_dome

Looking at the docker docs, it looks like the dockerfile parameter is distinct from the other path parameter.

$ cd /home/me/myapp/some/dir/really/deep
$ docker build -f /home/me/myapp/dockerfiles/debug /home/me/myapp
$ docker build -f ../../../../dockerfiles/debug /home/me/myapp

For what it's worth, we followed @tarikdem's suggestion and it worked for us.

from aws-ecr-orb.

iynere avatar iynere commented on September 3, 2024

thanks @tarikdem @sparta-developers ! looks like this orb's build-image command needs to be updated to match how we code this in our Docker orb:

- run:
    name: Docker build
    command: |
      docker_tag_args=""
      IFS="," read -ra DOCKER_TAGS \<<< "<< parameters.tag >>"
      for tag in "${DOCKER_TAGS[@]}"; do
        docker_tag_args="$docker_tag_args -t <<parameters.registry>>/<<parameters.image>>:${tag}"
      done
      docker build <<#parameters.extra_build_args>><<parameters.extra_build_args>><</parameters.extra_build_args>> \
        -f <<parameters.path>>/<<parameters.dockerfile>> \
        $docker_tag_args \
        <<parameters.path>>

feel free to submit a PR, should be fairly straightforward, otherwise we will get this taken care of shortly

from aws-ecr-orb.

iynere avatar iynere commented on September 3, 2024

patched in circleci/[email protected]

from aws-ecr-orb.

codebaard avatar codebaard commented on September 3, 2024

@tarikdem you saved my day. Had to deal with the exact same issue a whole day.

from aws-ecr-orb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.