Comments (4)
Would it be for the orb to alllow running goss (installing goss if it's not detected) on the built image with a user-provided goss yaml file?
@lokst Yup, that's what I was thinking about. Probably provide a flag goss_enabled
(may be smart that if there's no goss.yaml
just ignore is flag, otherwise default true) and if enabled, run dgoss
command at the end of the build process.
Also just realized I pasted the wrong URL in my previous question (also modified now in the original post). it is https://circleci.com/blog/testing-docker-images-with-circleci-and-goss/
from aws-ecr-orb.
I don't know if this addition neccesarily makes sense in the context of the orb - you might be better served with a goss orb (if one exists) with the build-image
command, which could either be in a job before the build-and-push-image
workflow or be in a job that uses the ecr-login
and push-image
commands. Unless we see a number of requests for this, I don't think it's a good fit, especially since we already offer the flexibility with the commands.
from aws-ecr-orb.
@ozooxo Could you elaborate on what kind of support you are thinking of? Would it be for the orb to alllow running goss (installing goss if it's not detected) on the built image with a user-provided goss yaml file?
from aws-ecr-orb.
Also of the opinion a "goss" orb may be the more flexible solution. It doesnt appear any "Goss" orbs have been created yet but may be a good candidate 👍
from aws-ecr-orb.
Related Issues (20)
- Error when upgrading to the aws-cli orb 4.1.2 HOT 2
- AWS ECR Credential Helper HOT 1
- Documentation inconsistency for circleci/[email protected] HOT 2
- Only the first --build-arg is passed to Docker build in v9.0.2 HOT 2
- Image indexes are pushed even when only one platform is specified HOT 10
- Expressions no longer evaluated? HOT 1
- Similar bug to https://github.com/CircleCI-Public/aws-ecs-orb/issues/206 HOT 2
- Image created is of type Image Index HOT 3
- All image builds broken until new release occurs HOT 9
- Cannot login to multiple ECRs with version 9.0.3 HOT 1
- `no basic auth credentials` on push_image step HOT 4
- E: The repository 'https://apt.kubernetes.io kubernetes-xenial Release' does not have a Release file. HOT 2
- Regression: cannot use AWS credentials in Dockerfile HOT 1
- Allow accessing registry of different account (--registry-id)
- Error when running `aws-ecr/build-image` on Alpine HOT 1
- Bugfix: PATH parameter does not override BUILD_PATH parameter as docs suggest
- build_and_push_image does not take in account the platform correctly HOT 1
- ECR login succeeds, but push fails with HEAD request 401 unauthorized HOT 11
- build to local and for one platform only and do not push image
- Error when providing multiple comma-separated platforms
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aws-ecr-orb.