Code Monkey home page Code Monkey logo

Comments (4)

ozooxo avatar ozooxo commented on September 3, 2024 1

Would it be for the orb to alllow running goss (installing goss if it's not detected) on the built image with a user-provided goss yaml file?

@lokst Yup, that's what I was thinking about. Probably provide a flag goss_enabled (may be smart that if there's no goss.yaml just ignore is flag, otherwise default true) and if enabled, run dgoss command at the end of the build process.

Also just realized I pasted the wrong URL in my previous question (also modified now in the original post). it is https://circleci.com/blog/testing-docker-images-with-circleci-and-goss/

from aws-ecr-orb.

gmemstr avatar gmemstr commented on September 3, 2024 1

I don't know if this addition neccesarily makes sense in the context of the orb - you might be better served with a goss orb (if one exists) with the build-image command, which could either be in a job before the build-and-push-image workflow or be in a job that uses the ecr-login and push-image commands. Unless we see a number of requests for this, I don't think it's a good fit, especially since we already offer the flexibility with the commands.

from aws-ecr-orb.

lokst avatar lokst commented on September 3, 2024

@ozooxo Could you elaborate on what kind of support you are thinking of? Would it be for the orb to alllow running goss (installing goss if it's not detected) on the built image with a user-provided goss yaml file?

from aws-ecr-orb.

KyleTryon avatar KyleTryon commented on September 3, 2024

Also of the opinion a "goss" orb may be the more flexible solution. It doesnt appear any "Goss" orbs have been created yet but may be a good candidate 👍

from aws-ecr-orb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.