Unable to specify a target image to build about aws-ecr-orb HOT 7 CLOSED

ahh, i see. you should already be able to do that by passing --target YOUR_TARGET to the extra-build-args parameter @rob4629

from aws-ecr-orb.

Great, thanks for confirming.

Update
That works, thank you for your swift resolution!

from aws-ecr-orb.

wouldn't you just use the push-image command in that case ? @rob4629

from aws-ecr-orb.

I'm planning to do that just now, it means adding in an additional docker build step (w/ target image specified) prior to push-image.

I was just wondering if the ability to specify a target build image existed, or if it was possible to add this functionality. (I'm not skilled enough to open a PR to add this functionality... and also don't know if others would find it useful)

from aws-ecr-orb.

well, this should help you w/ the docker build step @rob4629 http://github.com/circleci-public/docker-orb

i guess i'm not sure what you mean by 'target build' ? the idea here is that your 'target' is your ECR account url + your repo name + your tag, i believe

from aws-ecr-orb.

under the hood, all it's doing is this :

https://github.com/CircleCI-Public/aws-ecr-orb/blob/master/src/commands/build-image.yml#L41-L45

from aws-ecr-orb.

under the hood, all it's doing is this :
https://github.com/CircleCI-Public/aws-ecr-orb/blob/master/src/commands/build-image.yml#L41-L45

Right. All I was wondering was whether that command could be amended to

docker build \
          <<#parameters.extra-build-args>><<parameters.extra-build-args>><</parameters.extra-build-args>> \
          -f << parameters.dockerfile >> \
          -t $<< parameters.account-url >>/<< parameters.repo >>:<< parameters.tag >> \
          --target << parameters.target_image >> \
          << parameters.path >>

from aws-ecr-orb.