Code Monkey home page Code Monkey logo

Comments (4)

danroestorf avatar danroestorf commented on July 29, 2024 4

After reviewing the code I see that aws-ecr/build_and_push_image is only available as a job and not a command.

Would it be possible to expose this as a command? My configuration handles the deployment of multiple services in the repo and I would like to extract this step to a command.

from aws-ecr-orb.

iynere avatar iynere commented on July 29, 2024 4

yes, @danroestorf the issue you identified initially was the intended behavior. when jobs are super all-encompassing, it's v v convenient (in my experience) to only have to call them in your workflows config. however, providing both a job & command is even better & allows for more modular use-cases.

that said, are you aware of our pre-steps & post-steps features ?

https://circleci.com/docs/2.0/reusing-config/#using-pre-and-post-steps

they allow you to call a job in your workflows config but add in custom steps before and afterwards

anyway, i've merged @Tybot204's PR, so the newest version of this orb should allow you do to what you want here:

https://circleci.com/orbs/registry/orb/circleci/aws-ecr

from aws-ecr-orb.

Tybot204 avatar Tybot204 commented on July 29, 2024 1

Possibly something like this? #18

What will be difficult in the future about that implementation is having to manage both sets of parameters...

from aws-ecr-orb.

Tybot204 avatar Tybot204 commented on July 29, 2024

I also was having this issue trying to configure an orb I am writing for internal use on some projects. I would like to be able to create a job in my orb that calls this job with some preset parameters (which I believe means this job needs to be exposed as a command to work).

from aws-ecr-orb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.