Comments (6)
I see, thanks for the info - so just to make sure I understand things properly:
- cimplot and cimgui both can either be generated with or without the internal API, but basically cimplot has to be used together with a version of cimgui that has the setting set to the same value.
- the current cimplot master has the internal API turned on and hence also requires a cimgui with the internal API generation enabled
- imgui-rs currently vendors a version with the internal API turned off.
I've actually re-run the generator in my cimplot submodule with the internal API turned off, and that does seem to work out. So I think I can do two things: a) get imgui-rs to vendor the version with the internal API b) point my submodule to a cimgui fork that has the internal API turned off as well. It seems like a) may take a while (there is already an issue in imgui-rs/imgui-rs#395 for this, but it does not seem to be that active at the moment). I prefer not forking repos and creating maintenance effort, but it seems like b) may be a reasonable way forward for the moment.
from cimplot.
Where should
ImRect
andImPoolIdx
come from? I see they are inimgui.h
, but that's a C++ header.
They should come from cimgui.h (that is included from cimplot.h https://github.com/cimgui/cimplot/blob/master/cimplot.h#L7)
So if you update to latest cimplot you should also update cimgui.
from cimplot.
Ah, that makes sense. I've been using an older cimgui because of an unrelated issue, but I suppose you made those header changes in concert with cimgui. I'll go and resolve the unrelated issue then so I can also upgrade cimgui. Thanks for the help, this would have taken me a while to figure out.
from cimplot.
CIMGUI_DEFINE_ENUMS_AND_STRUCTS
will need to be defined
from cimplot.
Yes, that I've been doing all along, but it's really the issue you mentioned - I'm using an old cimgui, in fact the one that imgui-rs is vendoring in https://github.com/imgui-rs/imgui-rs/tree/master/imgui-sys/third-party, and that cimgui.h
just doesn't have ImRect
in it yet. I thought about adding cimgui as a submodule directly and generating off of that, but I think that might introduce tricky problems with interoperability between implot-rs and imgui-rs, which is very much needed for implot-rs to be of any use.
from cimplot.
cimgui.h has ImRect if it is generated for internal API.
I think that cimgui.h in imgui-rs was regenerated without internal API.
from cimplot.
Related Issues (13)
- add to cimgui organization? HOT 2
- Possibly add a version of the bindings with "internal" turned off HOT 10
- typedef ImPlotLocator using C++ references HOT 1
- Missing args for Plot_ShadedG when generating implot 0.14 HOT 15
- cannot link against implot HOT 7
- set custom path of implot and cimplot as generator's argument HOT 9
- Prebuilt Binaries? HOT 7
- Trigger binding regen for implot v0.4 HOT 1
- ImPlotPoint getters wrapping HOT 6
- Failed to compile the header cimplot.h because itβs not self-contained HOT 10
- How can it be 2047 unique cloners and only 18 stars HOT 4
- error: unknown type name 'time_t' HOT 23
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cimplot.