ciena-frost / ember-frost-navigation Goto Github PK
View Code? Open in Web Editor NEWHome Page: https://ciena-frost.github.io/ember-frost-navigation/
License: MIT License
Home Page: https://ciena-frost.github.io/ember-frost-navigation/
License: MIT License
It looks like liquid-fire has dropped support for its modal
. This issue, found here ember-animation/liquid-fire#484 blocks moving into ember: ^2.8.0
The best option would be to reimplement the modal.
~0.25.0
Update the lint functionality to come from ember-test-utils
testem.json
was never migrated to testem.js
after the Ember upgrade.
Migrate the necessary config from testem.json
to testem.js
and then delete the testem.json
file.
User Account shouldn't have description, so it should be centered.
or just remove all together
remark
and remark-lint
changed a bunch since it was implemented here. Most notably, see the [email protected]
changelog, and the releases for remark
page to find out more.
Or, feel free to ping us on Gitter or me below!
Cheers ๐
Titus
Change .nav-modal-outlet .nav-modal background color opacity to 0.97
ember-mocha
has deprecated the usage of describeComponent()
Update the describeComponent()
usage in our integration and unit tests to use our test helper that uses the new setupComponentTest() method.
Our category name is a SafeString since it comes from a translation plugin. While I can cast it to raw, I still believe this line:
I've been seeing the following error in an addon that's consuming ember-frost-navigation
:
Error: Assertion Failed: calling set on destroyed object: <dummy@service:frost-navigation::ember2063>._activeCategory = [object Null] (http://localhost:7357/assets/vendor.js:34795)
It's very strange because it happens in a test way after anything to do with ember-frost-navigation
. I tried guarding against the component itself being destroyed in #203, but that didn't seem to work. I'm gonna try guarding against the service itself being destroyed next.
When running the dummy app, click on "Category 1"
The following error is shown in the console:
ember.debug.js:18023 Assertion Failed: You attempted to define a `{{link-to "demo.blog"}}` but did not pass the parameters required for generating its dynamic segments. Assertion Failed: You attempted to mount the engine 'ember-blog-engine' in your router map, but the engine can not be found.
Feel free to modify, or add suggestions to the current list
@sglanzer @job13er
kebab-case
hooks to camelCase
, leaving -
to delimit sub-componentshookQualifiers
for indices, instead of appending -${index}
to the hook. And maybe include the name of the category as well.
$hook('category', {categoryIndex: 0})
// or
$hook('category', {categoryName: 'Stuff'})
// instead of
$hook('category-0')
.nav-colum:nth-child(1)
or something equivalent.i18n
support (by allowing consumers to pass in strings that will be rendered in DOM)Upgrade to the version release due to the resolution of ciena-frost/ember-frost-test#38
ciena-frost/ember-frost-popover#61 MUST be resolved before this issue can be addressed. Some of the individual tasks may be able to be worked on before the completion of the dependent issue. If doing so indicate which tasks have been completed by checking them off in the list below, as well as adding a comment to this issue indicating the name of the branch you have pushed to this repo so that work can completed once the dependent task has been addressed.
^
unless the directions in the tasks indicate otherwise.NPM
npm uninstall ember-frost-test
and ember install ember-frost-test
(verified)
ember-cli-chai
will be updated to 0.4.3
so may encounter issuesember-cli-mocha
will be updated to 0.14.4
so may encounter issuesember-sinon
will be updated to ^0.7.0
so may encounter issuesember-test-utils
will be updated to ^7.02
so will encounter issuesember-code-snippet
to 1.7.0
ember-prop-types
from devDependency and make dependencyuseLintTree
from ember-cli-mocha
configuration in ember-cli-build.jsBOWER
lodash
(verified)A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.