Code Monkey home page Code Monkey logo

ember-frost-navigation's People

Contributors

dafortin avatar ember-tomster avatar ewhite613 avatar greenkeeperio-bot avatar job13er avatar juwara0 avatar laflower avatar nicklewanowicz avatar notmessenger avatar quincyle avatar rox163 avatar sandersky avatar sglanzer avatar sophypal avatar srowhani avatar theotherdude avatar travis-ci-ciena avatar vesper2000 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

ember-frost-navigation's Issues

Remove testem.json in favor of testem.js

testem.json was never migrated to testem.js after the Ember upgrade.

Migrate the necessary config from testem.json to testem.js and then delete the testem.json file.

Trying to modify destroyed service?

I've been seeing the following error in an addon that's consuming ember-frost-navigation:

 Error: Assertion Failed: calling set on destroyed object: <dummy@service:frost-navigation::ember2063>._activeCategory = [object Null] (http://localhost:7357/assets/vendor.js:34795)

It's very strange because it happens in a test way after anything to do with ember-frost-navigation. I tried guarding against the component itself being destroyed in #203, but that didn't seem to work. I'm gonna try guarding against the service itself being destroyed next.

Clicking menu item in Dummy app results in {{link-to}} error

Problem

When running the dummy app, click on "Category 1"

The following error is shown in the console:

ember.debug.js:18023 Assertion Failed: You attempted to define a `{{link-to "demo.blog"}}` but did not pass the parameters required for generating its dynamic segments. Assertion Failed: You attempted to mount the engine 'ember-blog-engine' in your router map, but the engine can not be found.

screen shot 2017-08-11 at 7 40 25 am

Release 8.0 - Action List

Feel free to modify, or add suggestions to the current list
@sglanzer @job13er

  • Remove implicit routing from bind-dsl
  • Support public API accessible from service to mutate navigation
  • Add significant tests to the behavior expected from bind-dsl
  • Convert kebab-case hooks to camelCase, leaving - to delimit sub-components
  • Switch to using hookQualifiers for indices, instead of appending -${index} to the hook. And maybe include the name of the category as well.
    $hook('category', {categoryIndex: 0})
    // or
    $hook('category', {categoryName: 'Stuff'})
    // instead of
    $hook('category-0')
  • Fix hooks for columns within the nav modal so that a hook can select a specific section without needing to use .nav-colum:nth-child(1) or something equivalent.
  • Improve documentation
    • Include in README
    • Include in gh-pages dummy app
  • Add i18n support (by allowing consumers to pass in strings that will be rendered in DOM)

Address dependency management issues

ciena-frost/ember-frost-popover#61 MUST be resolved before this issue can be addressed. Some of the individual tasks may be able to be worked on before the completion of the dependent issue. If doing so indicate which tasks have been completed by checking them off in the list below, as well as adding a comment to this issue indicating the name of the branch you have pushed to this repo so that work can completed once the dependent task has been addressed.

  • Tasks that have the text "(verified)" after them are ones that have either already been tested or are known to work. This does not mean that you should not still be cautious but you likely don't have to do as much research as you might initially be inclinded to.
  • None of the tasks make a determination of whether a dependency should be a dependency or devDependency UNLESS otherwise stated. Even then it is prudent to confirm this indicator.
  • All dependencies should float to ^ unless the directions in the tasks indicate otherwise.

NPM

  • remove ember-cli-visual-acceptance (verified)
  • determine whether frost-guide-customer-routing is needed
  • remove ember-cli-deploy (verified)
  • remove ember-cli-deploy-frost-pack (verified)
  • determine whether ember-browserify is needed. if so ^1.2.0 is latest
  • npm uninstall ember-frost-test and ember install ember-frost-test (verified)
    • ember-cli-chai will be updated to 0.4.3 so may encounter issues
    • ember-cli-mocha will be updated to 0.14.4 so may encounter issues
    • ember-sinon will be updated to ^0.7.0 so may encounter issues
    • ember-test-utils will be updated to ^7.02 so will encounter issues
  • remove eslint from (verified)
  • remove eslint-config-frost-standard (verified)
  • remove remark-lint (verified)
  • remove sass-lint (verified)
  • pin ember-cli-code-coverage to 0.3.12
  • verify ember-cli-code-coverage is tied into "npm run test" script
  • pin ember-code-snippet to 1.7.0
  • upgrade ember-cli-sass to pinned 7.1.1 (verified)
  • determine whether ember-hook needs to be a dependency
  • downgrade and pin liquid-fire to 0.27.2
  • remove ember-redux
  • remove redux
  • remove redux-thunk
  • remove frost-guide-custom-routing
  • update or install ember-cli-frost-blueprints to ^5.0.0 (or whatever the latest release is) as devDependency
  • check whether these are specifically needed or not and remove if not, otherwise move to dependencies
    • ember-computed-decorators
    • ember-concurrency
    • ember-elsewhere
    • ember-truth-helpers
  • remove ember-prop-types from devDependency and make dependency
  • update ember-prop-types to ^6.0.0 (or whatever the latest release is)
  • update ember-frost-core to ^5.0.0 (or whatever the latest release is)
  • update ember-frost-notifier to latest version
  • update ember-frost-popover to latest version
  • remove useLintTree from ember-cli-mocha configuration in ember-cli-build.js

BOWER

  • move Faker to devDependencies of bower.json
  • move pretender to devDependencies of bower.json
  • remove lodash (verified)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.