Code Monkey home page Code Monkey logo

Comments (5)

cibernox avatar cibernox commented on May 22, 2024 1

Hey, good catch. I think this one slipped in a recent refactor. Please go ahead with the PR.

I'm worry tests didn't catch that one.

from ember-power-select.

srsgores avatar srsgores commented on May 22, 2024

I found the fix:

if (this.get('searchField')) {
      matcher = (option, text) => this.get("matcher")(get(option, this.get('searchField')), text);
    } else {
      matcher = (option, text) => this.get("matcher")(option, text);
    }

Notice I use get, short for this.get(), instead of trying to access the method directly from the class.

Want a PR?

from ember-power-select.

cibernox avatar cibernox commented on May 22, 2024

@srsgores Can you install the addon from master and check if it's fixed?

from ember-power-select.

cibernox avatar cibernox commented on May 22, 2024

@srsgores Can you confirm this is not an issue anymore?

from ember-power-select.

cibernox avatar cibernox commented on May 22, 2024

I'm closing this assuming that it's because you're on an version of Ember older that 1.13.9.

Let me know if it's not the case.

from ember-power-select.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.