Comments (6)
I can submit a PR for master if that helps grease the wheels for 2.0.11. :)
from wpfbogp.
@jjeaton looks ok i'd have to test it but looks fine.
Also would site_url not break if in multisite?
I'd like to make sure it won't break multisite, then feel free to pull to 2.0.10.
I'd like to really get this dev version out to production/repo but was having problem updating from the repo - it white-screened some sites and I had to revert.
from wpfbogp.
Will it break multisite? (I don't have a multisite install handy right now to test.)
http://queryposts.com/function/get_site_url/
site_url
just calls get_site_url
with null
for the blog_id
which defaults to the current blog, so while I don't have a quick way to test that right now, it "shouldn't" break anything.
from wpfbogp.
@chuckreynolds I finally got a multisite up and running on my vagrant setup and tested these changes on a multisite network. As I mentioned before, site_url works just fine with multisite, and I verified that relative images are prepended with the correct site_url (depending on the current site in the network). I'll submit another PR for the master branch as well for a hopeful 2.0.11 release. Thanks!
from wpfbogp.
merged into develop
and doing initial push to master
for 2.0.11 w/ this. need to test it then make sure there's nothing else I need to do to 2.0.11/master before pushing it into the wild. just backed up today. hopefully this weekend I can zip through this plugin
from wpfbogp.
Awesome thanks!
On Friday, May 16, 2014, Chuck Reynolds [email protected] wrote:
—
Reply to this email directly or view it on GitHubhttps://github.com//issues/33#event-122089520
.
from wpfbogp.
Related Issues (20)
- setup unit tests and travis stuff someday
- adding debugging support helpers to source output HOT 1
- look into force_fallback loop and get featimg working on pages that are the blog HOT 1
- Looking for feedback: Show fallback image if a featured image is found? HOT 6
- After upgrading to 2.0.12 it is adding trailing slash to url HOT 2
- trailing slashes being added onto urls with forced file names HOT 1
- update admin pages html after 4.3
- look at moving prefix to <head> instead of <html> per new doc recommendation
- quicknote: check title attrib vs the title HOT 1
- remove requirement for fb:admins and/or fb:app_id per latest spec
- should make description a little smarter
- test urls with params
- Admin screen heading tags with WordPress 4.4 HOT 1
- description feature request fix
- preg_replace() /e modifier is now deprecated. Instead, use the preg_replace_callback() function HOT 2
- Protocol-less image URLs aren't handled properly HOT 1
- Better sanitize ALL input fields
- Annoying advice in WPMU HOT 1
- setup notice on all pages: reconsider all pages, also make dissmissable
- Featured image chosen from gallery is not picked up as OpenGraph image HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wpfbogp.