Code Monkey home page Code Monkey logo

Comments (6)

jjeaton avatar jjeaton commented on May 27, 2024

I can submit a PR for master if that helps grease the wheels for 2.0.11. :)

from wpfbogp.

chuckreynolds avatar chuckreynolds commented on May 27, 2024

@jjeaton looks ok i'd have to test it but looks fine.
Also would site_url not break if in multisite?

I'd like to make sure it won't break multisite, then feel free to pull to 2.0.10.

I'd like to really get this dev version out to production/repo but was having problem updating from the repo - it white-screened some sites and I had to revert.

from wpfbogp.

jjeaton avatar jjeaton commented on May 27, 2024

Will it break multisite? (I don't have a multisite install handy right now to test.)

http://queryposts.com/function/get_site_url/

site_url just calls get_site_url with null for the blog_id which defaults to the current blog, so while I don't have a quick way to test that right now, it "shouldn't" break anything.

from wpfbogp.

jjeaton avatar jjeaton commented on May 27, 2024

@chuckreynolds I finally got a multisite up and running on my vagrant setup and tested these changes on a multisite network. As I mentioned before, site_url works just fine with multisite, and I verified that relative images are prepended with the correct site_url (depending on the current site in the network). I'll submit another PR for the master branch as well for a hopeful 2.0.11 release. Thanks!

from wpfbogp.

chuckreynolds avatar chuckreynolds commented on May 27, 2024

merged into develop and doing initial push to master for 2.0.11 w/ this. need to test it then make sure there's nothing else I need to do to 2.0.11/master before pushing it into the wild. just backed up today. hopefully this weekend I can zip through this plugin

from wpfbogp.

jjeaton avatar jjeaton commented on May 27, 2024

Awesome thanks!

On Friday, May 16, 2014, Chuck Reynolds [email protected] wrote:

Closed #33 #33.


Reply to this email directly or view it on GitHubhttps://github.com//issues/33#event-122089520
.

from wpfbogp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.