Allowing scalar input (Jacobi theta) about theta.jl HOT 4 OPEN

Thank you for the suggestion! I will look into writing a wrapper to allow scalar inputs.

As for the example that you gave, I think the problem is in the way that you define M. The following code works for me:

M = [0.794612+1.9986im]
R = RiemannMatrix(M)
z = [0.30657351+0.34017115im]
theta(z, RiemannMatrix(M))

from theta.jl.

Yes, that works for me too. I somehow thought I need to preserve the number of dimensions, hence the hcat. Thanks a lot!

from theta.jl.

This, however, fails if I try to specify a characteristic.
function θ(z, τ) M = [τ] R = RiemannMatrix(M) return theta([z], R, char=[1,1]) end
`
θ(randn(ComplexF64), 1.0im)
MethodError: no method matching +(::Vector{Float64}, ::Float64)
For element-wise addition, use broadcasting with dot syntax: array .+ scalar

Closest candidates are:
+(::Any, ::Any, ::Any, ::Any...)
@ Base operators.jl:578
+(::T, ::T) where T<:Union{Float16, Float32, Float64}
@ Base float.jl:408
+(::Union{MathOptInterface.ScalarAffineFunction{T}, MathOptInterface.ScalarQuadraticFunction{T}}, ::T) where T
@ MathOptInterface ~/.julia/packages/MathOptInterface/NCblk/src/Utilities/functions.jl:1783
...

Stacktrace:
[1] theta(z::Vector{ComplexF64}, R::RiemannMatrix; char::Vector{Int64}, derivs::Vector{Any}, derivs_t::Vector{Any})
@ Theta ~/.julia/packages/Theta/2Upgk/src/eval_theta.jl:42
[2] θ(z::ComplexF64, τ::ComplexF64)
@ Main ./In[51]:5
[3] top-level scope
@ In[55]:1

`

from theta.jl.

A simple hack that I have found works is: char=[[1],[1]], and replacing additions in line 42 and line 61 (in eval_theta) with the vectorized version as the debugger suggests:
x = real(z) + shift_x; # shift z by characteristic
to
`
x = real(z) .+ shift_x; # shift z by characteristic

And,
s = (2πim)^(nderivs) * sum([
(nderivs > 0 ? prod(transpose(d)(p-w) for d in derivs) : 1) * exp(2πim((0.5*(transpose(p-w)R.X(p-w))[1] + transpose(p-w)x)[1]) - π(transpose(p+w0)R.Y(p+w0))[1]) for p in E]); # compute sum over points in ellipsoid
to
s = (2πim)^(nderivs) * sum([
(nderivs > 0 ? prod(transpose(d)(p-w) for d in derivs) : 1) * exp(2πim((0.5*(transpose(p-w)R.X(p-w))[1] .+ transpose(p-w)x)[1]) - π(transpose(p.+w0)R.Y(p.+w0))[1]) for p in E]); # compute sum over points in ellipsoid
`
However, I am unsure if this is the most efficient way to do this.

from theta.jl.