Code Monkey home page Code Monkey logo

Comments (7)

chshersh avatar chshersh commented on June 1, 2024 1

@diasbruno I propose to have just options --stacked and --timeline with the --stacked being the default (I think timeline is a better name than interval now that I think about it). I don't anticipate adding a variety of styles to the tools so having a shorter CLI would be my preference here.

My idea is two have two separate modules under the DrCabal.Profile.* namespace: *.Stacked and *.Timeline. So the DrCabal.Profile just pattern matches on the values of the Style data type and calls corresponding functions.

I don't expect lots of code sharing between calculations and visualisation of these two different methods. Reading a JSON file and grouping a Map by libraries looks like the only things that can be reused. But if I were implementing this, I would write a new implementation from scratch completely and only after that see if I can refactor anything. Trying to reduce duplication may actually result in less readable and more confusing code so let's not do this prematurely 👍🏻

from dr-cabal.

diasbruno avatar diasbruno commented on June 1, 2024 1

Sounds great. I'll move things to the Stacked module first and the argument from cli (with default).

from dr-cabal.

diasbruno avatar diasbruno commented on June 1, 2024

In this case, are you thinking of grouping each package, start to finish in each row, or display each step of each package separate in order of execution?

from dr-cabal.

chshersh avatar chshersh commented on June 1, 2024

@diasbruno I'm thinking about grouping each package. So almost like the existing implementation but with blank spaces (probably using the space character) between phases where there's no progress on each phase.

from dr-cabal.

diasbruno avatar diasbruno commented on June 1, 2024

Nice. What argument should we use for this '--format' or '--style'?

from dr-cabal.

diasbruno avatar diasbruno commented on June 1, 2024

Like

dr-cabal profile --style {stacked|interval}

from dr-cabal.

diasbruno avatar diasbruno commented on June 1, 2024

I'll refactor/extract to a module what is implemented now, so it would help to add other styles.

from dr-cabal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.