Chord unparcelizing / deserializing throws SerializationException about chords HOT 7 CLOSED

Great! @chRyNaN any chance we can get a v2.4.1 bugfix release with these changes?

from chords.

@cullub Yes, I'll get another release out tonight.

from chords.

Tl;DR: this might be an issue with the serialization/parcelable library, but I'm not sure so I put the issue here. Making com.chrynan.parcelable.core.ParcelDecoder implement JsonDecoder would fix the exception, but I'm not sure if that's the right solution.

from chords.

I converted over this library to use my serialization-parcelable library. Unfortunately, I had to leave one custom serializer due to its complexity. But it looks like the serializer internally expects everything to be in Json format, but the serialization-parcelable library does not have the model in Json format. That seems to be why you are encountering this issue. The fix is to either update the custom serializer to work with serialization-parcelable, or to drop that dependency and bring back all of the custom parcelizers.

from chords.

@cullub The solution was rather simple. It seems my serialization-parcelable library works well with sealed classes. So I just replaced the @Serializable(with = ChordMarkerSerializer::class) from the ChordMarker model with @Serializable and it worked for me. I added the @SerialName() annotation to each of the sub-classes of the sealed class to make sure their type property matches appropriately in a Json format, but I haven't tested this yet.

from chords.

As it turns out, in my code I had only been using this feature in one place, and was able to replace it with another method, but the other couple things ( #11 specifically) are still needed for my latest update

from chords.

Version 2.4.1 (6) is released.

from chords.