Comments (7)
Great! @chRyNaN any chance we can get a v2.4.1 bugfix release with these changes?
from chords.
@cullub Yes, I'll get another release out tonight.
from chords.
Tl;DR: this might be an issue with the serialization/parcelable library, but I'm not sure so I put the issue here. Making com.chrynan.parcelable.core.ParcelDecoder
implement JsonDecoder
would fix the exception, but I'm not sure if that's the right solution.
from chords.
I converted over this library to use my serialization-parcelable
library. Unfortunately, I had to leave one custom serializer due to its complexity. But it looks like the serializer internally expects everything to be in Json format, but the serialization-parcelable
library does not have the model in Json format. That seems to be why you are encountering this issue. The fix is to either update the custom serializer to work with serialization-parcelable
, or to drop that dependency and bring back all of the custom parcelizers.
from chords.
@cullub The solution was rather simple. It seems my serialization-parcelable
library works well with sealed classes. So I just replaced the @Serializable(with = ChordMarkerSerializer::class)
from the ChordMarker
model with @Serializable
and it worked for me. I added the @SerialName()
annotation to each of the sub-classes of the sealed class to make sure their type
property matches appropriately in a Json format, but I haven't tested this yet.
from chords.
As it turns out, in my code I had only been using this feature in one place, and was able to replace it with another method, but the other couple things ( #11 specifically) are still needed for my latest update
from chords.
Version 2.4.1 (6)
is released.
from chords.
Related Issues (7)
- ChordChart.fretStart doesn't affect ChordWidget display HOT 3
- Colors library out of date/buggy
- Release build fails "unexpected attempt to get register for a value without a method" HOT 2
- after adding new item(barChord) unable to scroll open chord HOT 11
- Publish new release? HOT 1
- Bintray hosting shut down HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chords.