all_fields_required with optional about protoc-gen-jsonschema HOT 5 OPEN

Hi @k-jay-c, yeah OK I see what you're saying here. Let me take a look and figure out how easy this would be to implement.

from protoc-gen-jsonschema.

Alright, one thing to mention is that this would only ever apply to Proto2 (as with Proto3 we have to assume the defaults, being every field is optional).

from protoc-gen-jsonschema.

Hi @chrusty,

I believe this logic can apply to Proto3 as well. By applying the flag "all_fields_required", we're overwriting the default proto3 behaviour. This enhancement allows for more fine grained control to define which fields to treat as required. Alternative could be a new flag - all_non_optional_fields_required?

Thanks,
Jay.

from protoc-gen-jsonschema.

FWIW I would find very useful to be able to mark as required only the "non-optional" fields. On proto3 they have re-added optional too, and the rationale is a bit complex to follow, but it's available here.
In our project we are basically following what they call Explicit presence discipline but at the end we try to use the .proto files also to build our datamodel schema, and we assume that if a field does not have the "optional" keyword should be treated as required.

from protoc-gen-jsonschema.

@chrusty sorry to bother, but are there any news about this issue?

from protoc-gen-jsonschema.