Windows: Add windowed rendering support about java-cef HOT 9 CLOSED

Comment 1. originally posted by magreenblatt on 2014-01-22T16:40:35.000Z:

Thanks for the patch. Some comments:

1. line 164:

• if(CefContext.isMacintosh() ) {

Style says this should be "if (CefContext.isMacintosh()) {". Same in other places.

2. line 422:

• public void onTakeFocus(CefClient client, boolean next) {
• if( next ) {

•  backButton\_.requestFocus();  
  

• }
• else {

•  goButton\_.requestFocus();  
  

• }
• }

Instead of manually programming the tab order is there a way to pass the event to Java and have it focus the next control automatically?

3. line 462:

• HWND handle = browser->GetHost()->GetWindowHandle();
• SetWindowPos(handle, NULL, 1, 1, width-1, height-1, SWP_NOZORDER | SWP_NOMOVE);

Why the 1 pixel offset?

4. line 480:

• browser->GetHost()->SetFocus(enable == JNI_TRUE);
• browser->GetHost()->SendFocusEvent(enable == JNI_TRUE);

SetFocus is for windowed browsers and SendFocusEvent is for osr browsers. You shouldn't call both.

from java-cef.

Original comment by Anonymous.

Comment 2. originally posted by [email protected] on 2014-01-24T11:08:20.000Z:

Thanks for reviewing the patch.
Regarding your questions and comments:

1.) Yes, styling is fixed now (see issue #31)

2.) Yes, I've found a a way to do this. I changed the code to use
the FocusTraversalPolicy which is responsible for the traversal chain.
From this policy object I get the first/last object in the chain to pass
the focus over.

3.) Sorry that sliped in. This was only a testcase on my side and I've removed
the offset now.

4.) Thanks for the hint. I didn't knew that. I've added an if-clause to it.

See attached patch-file for my changes.
Please note that this patch file depends on the patch from issue comment 31..

from java-cef.

Original comment by Anonymous.

Comment 3. originally posted by [email protected] on 2014-01-27T08:25:15.000Z:

Sorry, but I forgot to add a java include to MainFrame.java.

So, here is a new version of the patch file.

from java-cef.

Comment 4. originally posted by magreenblatt on 2014-01-30T19:04:05.000Z:

Added in revision 22 with minor style and documentation changes changes.

I've disabled windowed rendering by default on Windows because I'm getting the following crash while resizing the window: http://magpcss.org/ceforum/viewtopic.php?f=6&t=10415. We'll need to fix this before enabling windowed rendering by default.

from java-cef.

Comment 5. originally posted by magreenblatt on 2014-02-20T17:13:34.000Z:

@ commentcomment 4.: The resize issue has been fixed by the CEF 1750 branch update. Revision 30 enables windowed mode by default.

from java-cef.

Original changes by Anonymous.

• set attachment to "2014-01-23_04-added_windowed_rendering_for_win.patch"

from java-cef.

Original changes by Anonymous.

• set attachment to "2014-01-27_04-added_windowed_rendering_for_win.patch"

from java-cef.

• set state to "open"

from java-cef.

• set state to "resolved"

from java-cef.