Mac: Use ant and appbundler instead of scripts about java-cef HOT 9 CLOSED

Original comment by Anonymous.

Comment 1. originally posted by [email protected] on 2014-01-15T11:36:21.000Z:

Please update the wiki page BranchesAndBuildings as well. See attached patch

from java-cef.

Original comment by Anonymous.

Comment 2. originally posted by [email protected] on 2014-01-17T07:07:22.000Z:

One additional patch-file to avoid problems with Windows compatibility (there is a problem if the library path is corrected within CefContext.cpp).

Please add 2014-01-15_03-moved_to_ant_app_bundle_creation.patch first and afterwards add this attached patch file.

from java-cef.

Comment 3. originally posted by magreenblatt on 2014-01-22T15:28:04.000Z:

Thanks for the patch. A few questions:

1. 2014-01-15_03-moved_to_ant_app_bundle_creation.patch line 196:

• const std::string& module_dir = GetJNIString(env, argPathToJavaDLL);

• std::string module_dir = GetJNIString(env, argPathToJavaDLL);
• std::size_t endPos = module_dir.find(':');
• module_dir = module_dir.substr(0,endPos);

Can you explain why this is necessary?

2. 2014-01-15_03-moved_to_ant_app_bundle_creation.patch line 583:

•  export CLS\_PATH="$OUT\_PATH/jcef.jar:$OUT\_PATH/jcef-tests.jar:$OUT\_PATH/gluegen-rt.jar:$OUT\_PATH/gluegen-rt-natives-macosx-universal.jar:$OUT\_PATH/jogl-all.jar:$OUT\_PATH/jogl-all-natives-macosx-universal.jar"  
  

Can we use a wildcard ($OUT_PATH/*) instead of specifying the full name of each jar file?

from java-cef.

Original comment by Anonymous.

Comment 4. originally posted by [email protected] on 2014-01-24T11:06:29.000Z:

Thanks for reviewing the patch.
Regarding your questions:

1.)
The function Java_org_cef_CefContext_N_1Initialize is called by Java with
System.getProperty("java.library.path"); as value for the param argPathToJavaDLL.

According Java's definition, the property "java.library.path" can contain more
than one path to search for libraries. These paths are separated by the character
which is stored within the property "path.separator" (":" for UNIX and ";" for Windows).
(see http://docs.oracle.com/javase/7/docs/api/java/lang/System.html\#getProperties())

So if you use JCEF within great projects, you'll get soon or later problems by
interpreting the property value of "java.library.path" as only one path. Most of
the big projects may have not only one lib-path to search in and so you'll get a
non valid path passed to the native world.

As a workaround of this problem I've added that "split" patch to the function, so
that only one (and not a bunch of paths) path is passed to "GetHeplerPath()",
append to "settings.resources_dir_path" and append to "settings.locales_dir_path".

BUT: You're right. There are some problems with this patch:
(1) I forgot that there are different path separators on different systems
(2) Maybe not in every case the first path is that one which contains the jcef lib.
(3) Maybe the file for the patch isn't the best choice.

For that reason I've removed the patch from CefContext.cpp and added a more concrete
one to CefContext.java. The Java-Patch splits "java.library.path" by "path.separator"
and searches within the directory for the JCEF lib. If it contains it, the single
path is passed to the native world.

2.)
Yes you're right. Addressing several JARs within the same directory is nonsense.
So, I've reduced it to the wildcard pattern as suggested by you.

See attached patch-file for my changes.

from java-cef.

Comment 5. originally posted by magreenblatt on 2014-01-30T17:16:29.000Z:

Added in revision 18 with minor style changes. Also updated the distrib scripts.

from java-cef.

Original changes by Anonymous.

• set attachment to "2014-01-15_ANT_BranchesAndBuilding.wiki.patch"

from java-cef.

Original changes by Anonymous.

• set attachment to "2014-01-17_03-moved_to_ant_app_bundle_creation_update_for_win_compatibility.patch"

from java-cef.

Original changes by Anonymous.

• set attachment to "2014-01-23_03-moved_to_ant_app_bundle_creation.patch"

from java-cef.

• set state to "resolved"

from java-cef.