Code Monkey home page Code Monkey logo

Comments (4)

ChristopherBiscardi avatar ChristopherBiscardi commented on August 25, 2024 1

The React import with the player is what I meant :) because the <Player> compiles to React.createElement, so React has to be in scope.

from christopherbiscardi.github.com.

ChristopherBiscardi avatar ChristopherBiscardi commented on August 25, 2024

@spences10 did you get this worked out? I remember we had a short conversation about it on Twitter

from christopherbiscardi.github.com.

ChristopherBiscardi avatar ChristopherBiscardi commented on August 25, 2024

Also, you probably need import React from 'react' at the top of your globalScope. I use gatsby-plugin-emotion here which changes my createElement implementation, so I don't actually need React in scope for mine.

from christopherbiscardi.github.com.

spences10 avatar spences10 commented on August 25, 2024

Hey @ChristopherBiscardi, I used @kentcdodds remark-embedder plugin in the end as it solved the twitter embed issue I was having as well.

But for clarity when you say globalScope what is it that you mean? I thought that I would need to include something with wrapRootElement?

Or literally have the React import statement with the player import?

globalScope: `
import React from 'react';
import Player from 'react-player'; 
 export default { 
   Video: props => <Player {...props} css={{ 
     margin: 'auto', 
     paddingBottom: '1.5rem' 
   }}/> 
 }
`,

Like this ☝️

Closing this now.

from christopherbiscardi.github.com.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.