Code Monkey home page Code Monkey logo

Comments (6)

christiangalsterer avatar christiangalsterer commented on July 18, 2024 1

The fix is included in the new version 2.3.2 available in the Atlassian Marketplace.

from bitbucket-asciidoc-plugin.

christiangalsterer avatar christiangalsterer commented on July 18, 2024

Which plugin and Bitbucket version do you use?

from bitbucket-asciidoc-plugin.

christiangalsterer avatar christiangalsterer commented on July 18, 2024

I have tried it with the latest version of the plugin and the latest version of Bitbucket and I can't reproduce the issue. Can you doublecheck that all files have been pushed/merged correctly?

from bitbucket-asciidoc-plugin.

mkobit avatar mkobit commented on July 18, 2024

@christiangalsterer sorry, I haven't look back at this but will check again today.

from bitbucket-asciidoc-plugin.

mkobit avatar mkobit commented on July 18, 2024

Sorry for taking so long to get back to you, I don't think I described the issue well so hopefully the steps below clarify the issue

Here are the steps I followed locally using the atlas-run-standalone -p 7990 --context-path / --version 4.10.0 --product bitbucket and testing with https://github.com/asciidoctor/jekyll-asciidoc.

  1. Run atlas-run-standalone -p 7990 --context-path / --version 4.10.0 --product bitbucket

  2. Login with admin/admin

  3. Install the 2.3.1 version

  4. Create a repository

  5. Clone down https://github.com/asciidoctor/jekyll-asciidoc, change upstream

    git clone https://github.com/asciidoctor/jekyll-asciidoc.git
    cd jekyll-asciidoc
    git remote set-url origin http://admin@localhost:7990/scm/project_1/my-repo.git
    
  6. Checkout out new branch

    git checkout -b issue-12-repro
    
  7. Download an image

    curl https://www.brandeps.com/logo-download/B/Bitbucket-01.png -o bitbucket-logo.png
    
  8. Make a tweak to the README.adoc to use include::[] macro.

    == Overview
    
    Here is the Bitbucket logo!
    
    image::bitbucket-logo.png[]
    
  9. Add, commit, and push

    git add README.adoc bitbucket-logo.png
    
  10. Preview a pull request to the master branch (http://localhost:7990/projects/PROJECT_1/repos/my-repo/compare/commits?sourceBranch=refs/heads/issue-12-repro)

    Pull request preview

  11. Select the "full source" button

    View full source button

  12. See broken image on page

    Broken image link and source

from bitbucket-asciidoc-plugin.

christiangalsterer avatar christiangalsterer commented on July 18, 2024

Hi @mkobit,

thank you very much for the detailed description. I was now able to reproduce the issue. The problem is that the link is created against the configured default branch.

I will look into it and will have a fix hopefully soon.

from bitbucket-asciidoc-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.