constructFormattedURL / needs a rethink about celestial HOT 3 CLOSED

  func convertURLToUniqueFileName() -> String {
        guard let _ = URL(string: self) else {
            fatalError("\(self) is not a valid URL")
        }
        return self.md5
    }
    

from celestial.

on an out of date branch.

from celestial.

I think using lastPathComponent + md5 is better way to handle filenames.

https://blablabla.com/test.mp4 -> test.mp4 -> 123412341234123412343
sourceURL.lastPathComponent.convertURLToUniqueFileName()

func convertURLToUniqueFileName() -> String {
guard let _ = URL(string: self) else {
fatalError("(self) is not a valid URL")
}
return self.md5
}

It's possible the urls will be too large for file system.

/tmp/. Directory contents: ["httpsd21m91m763fb64.cloudfront.netvideos-540p19f1efb0-8a1e-11eb-8bc7-65134f4b7bab-.mp4", "https:__d21m91m763fb64.cloudfront.net_videos-540p_d9379510-903f-11eb-9a88-f5ff80ee2719-.mp4", "https:__d21m91m763fb64.cloudfront.net_videos-540p_9edc1cd0-a9f1-11eb-b98a-69bcf457ca9a-.mp4", "httpsd21m91m763fb64.cloudfront.netvideos-540pe4b390e0-8560-11eb-822b-3bb0ffb6770c-.mp4", "https:__d21m91m763fb64.cloudfront.net_videos-540p_22114af0-82cc-11eb-a662-35cb0ee94b96-.mp4", "stack-logs.3760.10e1dc000.8secondz.8SFCWk.index", "https:__d21m91m763fb64.cloudfront.net_videos-540p_51180470-9856-11eb-968f-297a20a6926d-.mp4", "instrument", "https:__d21m91m763fb64.cloudfront.net_videos-540p_b28a8d60-7dfb-11eb-aff5-433e586b7aee-.mp4

I can't explain why - but I'm seeing inexplicable failure to move the file from tmp to Celestial folder.

I'll draft a new branch with last path component for your review.

from celestial.