Job::recreate() encapsulates args array inside another array about php-resque HOT 8 CLOSED

A PR would be better :)

from php-resque.

The trouble with a pull request at this point is the question of why $args is being wrapped in an(other) array. Should it, instead, be cast to an array? Knowing why it is wrapped will determine which of the two solutions should be submitted in a PR to begin with.

from php-resque.

True, I found out this:

The encapsulated array() call in Job::create was added 2 years ago in order to be better compatible with the Ruby version: f7eac3b

When you look at Job->getArguments() you'll see that it then returns the first index of the array: https://github.com/chrisboulton/php-resque/blob/master/lib/Resque/Job.php#L128

So this should be correct:

return self::create($this->queue, $this->payload['class'], $this->payload['args'][0], $monitor);

from php-resque.

Maybe $this->getArguments() would be better as it returns an empty array when there are no arguments given. Where $this->payload['args'][0] could throw an undefined index error.

from php-resque.

You make it sound like git keeps a record of changes, and if commit messages are actually thoughtfully written, others can go back and see why things are done a certain way! A technology like that would be.... Well, useful.

Said another way: Oh. Right. The answer is probably in the commit history somewhere, and something like git blame would probably help narrow down where. Duh. Should have thought of that.

from php-resque.

yeah $this->getArguments() would be the proper way to do it, like you said, in case $this->payload['args'][0] is undefined. Pull request sent, thanks guys.

from php-resque.

It looks like this issue could be closed? Fixed in #104

from php-resque.

True @Rockstar04

from php-resque.