The recorder object is intended to be reused and thus holds onto the stream
and the users permissions. The code you provided will stop the stream
properly, if you want the memory to be freed, you should also remove all
your event listeners as well. Javascript doesn't provide a nice way to
destroy objects so I left it out. When the recorder stops, the workers are
destroyed and the audio nodes disconnected from the destination so the
memory usage should minimal, and no extraneous events should be firing. Let
me know if this is in line with what you experience.

On 4 May 2015 at 16:09, Kequc [email protected] wrote:

The first time an instance of Recorder is created, the user is asked for
access to their microphone. In chrome this adds a red icon to the tab.
There isn't any way seemingly to end the stream.

In my application I'm creating a new Recorder instance each time I want to
record, is this an incorrect way to do things? I've added this.

recorder.addEventListener 'stop', =>
if recorder && recorder.stream
recorder.stream.stop()

It would be nice if I could de-initialise the stream as an intended
feature of the library.

—
Reply to this email directly or view it on GitHub
#13.

from opus-recorder.

Forgot to say thanks for your comment, and I will consider adding a destroy() method if It could be implemented nicely.

from opus-recorder.

The reason I suppose I bring it up is that users might be confused and think their browser is still listening to them. Which it could. I love this library by the way, I was dealing with just raw pcm before I found this. Good work, everyone past and present who has worked on it.

from opus-recorder.

Here is my solution to do what I wanted. Taking into consideration that you said the Recorder is intended to be reused.

_closeStream: =>
  # Close recorder stream

  if @recorder && @recorder.stream
    @recorder.stream.stop()
  @status.ready = false

start: =>
  # Start recording
  return false if @status.active || @status.ready

  @status.active = true

  if @recorder
    @recorder.initStream()

  else
    @recorder = new Recorder
      recordOpus:
        stream: true

    @recorder.addEventListener 'streamReady', =>
      if @status.active
        @status.ready = true
        @recorder.start()
      else
        @_closeStream()

    @recorder.addEventListener 'stop', =>
      @_closeStream()

  true

stop: =>
  # Stop recording
  return false unless @status.active

  @status.active = false

  if @recorder
    @recorder.stop()

  true

The idea is that a stream is closed when the recorder is stopped and a new stream is initialised on start. This serves my needs. I hope it's not too messy looking.

from opus-recorder.

Looks good. I believe you can safely call start and stop and if recorder
is not in the right state nothing will happen. Recorder is also storing its
state in recorder.state (inactive, recording, or paused) if you want to
read from it as well.

On 5 May 2015 at 11:55, Kequc [email protected] wrote:

Here is my solution to do what I wanted. Taking into consideration that
you said the Recorder is intended to be reused.

_closeStream: =>

Close recorder stream

if @recorder && @recorder.stream
@recorder.stream.stop()
@status.ready = false

start: =>

Start recording

return false if @status.active || @status.ready

@status.active = true

if @recorder
@recorder.initStream()

else
@recorder = new Recorder
recordOpus:
stream: true

@recorder.addEventListener 'streamReady', =>
  if @status.active
    @status.ready = true
    @recorder.start()
  else
    @_closeStream()

@recorder.addEventListener 'stop', =>
  @_closeStream()

@recorder

stop: =>

Stop recording

return false unless @status.active

@status.active = false

@recorder.stop()

The idea is that a stream is closed when the recorder is stopped and a new
stream is initialised on start. This serves my needs. I hope it's not too
messy looking.

—
Reply to this email directly or view it on GitHub
#13 (comment)
.

from opus-recorder.

Heads-up that i have experienced empty buffers when starting recording
immediately after initializing the stream. Which is one of the reasons I
initialize the stream on init instead of recording start.

On 5 May 2015 at 14:52, Chris Rudmin [email protected] wrote:

Looks good. I believe you can safely call start and stop and if recorder
is not in the right state nothing will happen. Recorder is also storing its
state in recorder.state (inactive, recording, or paused) if you want to
read from it as well.

On 5 May 2015 at 11:55, Kequc [email protected] wrote:

Here is my solution to do what I wanted. Taking into consideration that
you said the Recorder is intended to be reused.

_closeStream: =>

Close recorder stream

if @recorder && @recorder.stream
@recorder.stream.stop()
@status.ready = false

start: =>

Start recording

return false if @status.active || @status.ready

@status.active = true

if @recorder
@recorder.initStream()

else
@recorder = new Recorder
recordOpus:
stream: true

@recorder.addEventListener 'streamReady', =>
  if @status.active
    @status.ready = true
    @recorder.start()
  else
    @_closeStream()

@recorder.addEventListener 'stop', =>
  @_closeStream()

@recorder

stop: =>

Stop recording

return false unless @status.active

@status.active = false

@recorder.stop()

The idea is that a stream is closed when the recorder is stopped and a
new stream is initialised on start. This serves my needs. I hope it's not
too messy looking.

—
Reply to this email directly or view it on GitHub
#13 (comment)
.

from opus-recorder.

Stream now stops when recording is finished.

from opus-recorder.