Comments (10)
Nice! Progress looks great so far!
from censusxy.
@chris-prener Could you implement the continuous integration for me? I would rather not create travis/appveyor accounts and not sure of best practice implementation.
from censusxy.
yep - I'll do that now
from censusxy.
OK @bransonf - I cleaned up some code and some of the package infrastructure and added a bunch of items to the to-do list. Nothing major, I don't think! Nice work on getting these API calls sorted out.
A couple questions for cxy_geocode
:
- why is this named 'response'? is there a reason not to overwrite 'split'?
- the left_join's performance could be improved if we used one variable instead of 4... can we use id?
A couple questions for cxy_geocoder
:
- what is the practical impact of using a warning in an internal function... I'm not sure about this
- why call
methods::as()
instead ofas.numeric()
?
from censusxy.
Also, FWIW, appyveyor is failing because the new dplyr
release's binaries aren't out yet and for some reason the source builds are failing. On the Travis side, it is failing on 3.3 and 3.4 because of the serialization issue I noted above.
from censusxy.
What do we do about the appveyor issue?
Reason to not overwrite split, as I understand (Could be wrong about this) is that initializing an empty vector pre-allocates memory for data to be put into. If the function re-wrote to the split object, it would put it in a new section of memory, and it would have to call the new object every iteration in the loop. (Causing an exponential slow down) Even if I'm wrong about that, the worst risk of using another object is using a bit more memory.
I'm not really happy about the left_join part at all. I never found a solution for unique id to row id. I would like to create a list of only unique addresses to send to the geocoder and then join that UID to a regular ID.
Dependency on methods and internal warning are remnants of early development, they've been removed. The error for all Non-Matches takes care of what the internal warning was meant for.
from censusxy.
And a note about the testing, we won't technically get full coverage without using more than 1000 addresses, but I'm confident that if something would fail in the batch process, it would also fail on the smaller data.
from censusxy.
OK - totally fine with split
and glad you made those other changes. I made a couple of small tweaks to the unit test and fixed a documentation issued that R CMD check
identified.
We're still failing one of the unit tests, which is connected to what happens when the data have a state
column but it isn't included in the function call. This is something we need to address. Can you check that out?
That same solution is implemented in parts of both gateway
and postmaster
for the UID... do you want me to add that or do you want to explore how it works in those packages?
from censusxy.
RE: appveyor and Travis failing - the dplyr
binaries should be available early this week and that should resolve any outstanding issues. As long as devtools::check()
is doing well locally, I'm not concerned.
from censusxy.
OK - almost ready to fork and submit to CRAN - we just need to let the stack of CI builds wrap up!
from censusxy.
Related Issues (20)
- Travis CI needs migration
- Malformed Response Data HOT 4
- General feedback
- Integrate Github Actions HOT 2
- Non-ASCII characters lead to NA geocoding records HOT 3
- tie HOT 7
- GitHub Actions HOT 2
- cxy_geocode function no longer returning county names when output field specified as "full" HOT 4
- Issue with address batch n > 3 HOT 6
- CRAN issue HOT 4
- vignette typo
- code coverage not working HOT 1
- Update Docs/News with Parallel Support HOT 1
- Inconsistent geocoding (singe vs batch) HOT 1
- Cannot Get Sample to Run HOT 5
- Track + cache progress HOT 3
- cxy_geocode arguments returning "object ___ not found" for existing objects HOT 4
- Parallel processing fails on macOS HOT 7
- `_pkgdown.yml` issue
- Census API failing to return vintages
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from censusxy.