ESPG=4326 is not recognised about oceanmesh HOT 3 OPEN

seems to be a good fix

The function docstring says:

    crs: A Python int, dict, or str, optional
        The coordinate reference system

if that is the case, and a dict is acceptable too, then you should probably take that into account, too.

That being said, since crs is an argument that is used in many functions, fixing all the instances is probably out of scope for #68. "Syncing" the code with the docs should probably happen in a dedicated PR. In that case, replacing the integers with strings in the tests is probably more appropriate.

from oceanmesh.

@tomsail no, I can follow. feel free. thanks for putting in the effort here.

from oceanmesh.

Actually as I progress doing our Iceland test case, I found more bugs/fixes to implement in various functions.
I agree that correcting & addressing different issues with different PR is the way to go, although it might be confusing for @krober10nd to understand what's going on.

if that is the case, and a dict is acceptable too, then you should probably take that into account, too.

some functions implement the CRS class from pyproj but it is not consistent across the whole package

from oceanmesh.