Support defaulting launch & proc-run to use $SHELL with option for --no-shell otherwise about distant HOT 5 CLOSED

It looks like we may actually need the login shell option. Bash, ksh, fish, and zsh support providing a login shell and command option together <shell> -l -c env. The shells csh and tcsh do not, but the recommendation is to do something like echo ls | tcsh -l.

So idea would be to do something like echo 'distant ...' | $SHELL -l

from distant.

Resolved by 160631b

from distant.

If you integrate libssh or libssh2, you can have the sshd give you a login shell by requesting a shell explicitly, and then you can send your commands on stdin, which is sort of in alignment with your comment above, but you shouldn't need to play around with $SHELL or figuring out how to spawn a login shell.

Also note that if you were in control of the spawning directly (which I know you're not in this case), spawning a login shell can be done this way in rust:

            let shell = Self::get_shell()?;
            let mut cmd = std::process::Command::new(&shell);
            // Run the shell as a login shell by prefixing the shell's
            // basename with `-` and setting that as argv0
            let basename = shell.rsplit('/').next().unwrap_or(&shell);
            cmd.arg0(&format!("-{}", basename));

https://github.com/wez/wezterm/blob/main/pty/src/cmdbuilder.rs#L190-L197

from distant.

FWIW, the $SHELL -l thing doesn't work with fish; I know because that's the technique I used to use in wezterm!

from distant.

from distant.