Right now, both backends are required to compile CHIP-SPV. Should be able to compile&a

Might not be 100% fixed yet: <div class="snippet-clipboard-content notranslate pos

That was a one-off issue patched with: <div class="highlight highlight-source-c++

fixed by PR <a class="issue-link js-issue-link" data-error-text="Failed to load title"

don't require both backends to compile about chipstar HOT 4 CLOSED

franz commented on June 14, 2024

don't require both backends to compile

from chipstar.

Comments (4)

franz commented on June 14, 2024

Fixed

from chipstar.

pjaaskel commented on June 14, 2024

Might not be 100% fixed yet:

/home/visit0r/src/chip-spv/src/CHIPDriver.cc:146:19: error: unknown type name 'CHIPBackendOpenCL'
    Backend = new CHIPBackendOpenCL();

from chipstar.

pjaaskel commented on June 14, 2024

That was a one-off issue patched with:

--- a/src/CHIPDriver.cc
+++ b/src/CHIPDriver.cc
@@ -143,7 +143,13 @@ extern hipError_t CHIPReinitialize(const uintptr_t *NativeHandles,
       logDebug("CHIP_BE was not set. Defaulting to OPENCL");
     else
       logDebug("CHIPBE=OPENCL... Initializing OpenCL Backend");
+#ifdef HAVE_OPENCL
     Backend = new CHIPBackendOpenCL();
+#else
+    CHIPERR_LOG_AND_THROW("Invalid CHIP-SPV Backend Selected. This CHIP-SPV "
+                          "was not compiled with OpenCL backend",
+                          hipErrorInitializationError);
+#endif
   } else if (!CHIPBackendType.compare("level0")) {
     logDebug("CHIPBE=LEVEL0... Initializing Level0 Backend");
     Backend = new CHIPBackendLevel0();

But also at linkage it seems to want OpenCL symbols.

[ 57%] Linking CXX executable hip_async_binomial
/usr/bin/ld: CMakeFiles/hip_async_binomial.dir/BinomialOptionOpenCL.cpp.o: in function `runOpenCLKernel':
BinomialOptionOpenCL.cpp:(.text+0xb3): undefined reference to `clCreateProgramWithIL'
/usr/bin/ld: BinomialOptionOpenCL.cpp:(.text+0x13a): undefined reference to `clBuildProgram'
/usr/bin/ld: BinomialOptionOpenCL.cpp:(.text+0x183): undefined reference to `clGetProgramBuildInfo'
/usr/bin/ld: BinomialOptionOpenCL.cpp:(.text+0x1e3): undefined reference to `clGetProgramBuildInfo'
/usr/bin/ld: BinomialOptionOpenCL.cpp:(.text+0x278): undefined reference to `clCreateKernel'
/usr/bin/ld: BinomialOptionOpenCL.cpp:(.text+0x2c4): undefined reference to `clSetKernelArg'
/usr/bin/ld: BinomialOptionOpenCL.cpp:(.text+0x30a): undefined reference to `clSetKernelArgSVMPointer'
/usr/bin/ld: BinomialOptionOpenCL.cpp:(.text+0x350): undefined reference to `clSetKernelArgSVMPointer'
/usr/bin/ld: BinomialOptionOpenCL.cpp:(.text+0x42a): undefined reference to `clEnqueueNDRangeKernel'

from chipstar.

franz commented on June 14, 2024

fixed by PR #113

from chipstar.

Recommend Projects