Comments (7)
pvelesko
commented on June 14, 2024
1
I do not know if we can make it more graceful, as long as the user sees it's because of missing capabilities and not just crash, I think there's not much else we can do.
Ok so sounds like we don't have an issue in that regard then since we already print the exact error.
Should we add a separate test suite for the double tests since they are not supposed to work on OpenCL/LZ devices which do not provide double support?
Sounds like good idea and something we can consider for the next release. I haven't come across a device that doesn't support double precision (so no way of testing) so it doesn't seem like a high-priority issue at this time.
from chipstar.
pvelesko
commented on June 14, 2024
All the known failures have been documented on the wiki as part of the 0.9
release. If you have additional tests that fail for you then we should
investigate.
…On Thu, Sep 8, 2022, 14:22 Pekka Jääskeläinen ***@***.***> wrote:
Are these known? Happens with my Iris Xe mobile GPU.
Shall we remove them as known-failing tests or have another check rule for
known-passing OpenCL tests?
The following tests FAILED:
108 - Unit_hipHostGetFlags_Basic - int (Failed)
109 - Unit_hipHostGetFlags_Basic - float (Failed)
110 - Unit_hipHostGetFlags_Basic - double (Failed)
111 - Unit_hipMallocManaged_MultiChunkSingleDevice (Failed)
112 - Unit_hipMallocManaged_MultiChunkMultiDevice (Failed)
115 - Unit_hipMallocManaged_TwoPointers - int (Failed)
116 - Unit_hipMallocManaged_TwoPointers - float (Failed)
117 - Unit_hipMallocManaged_TwoPointers - double (Failed)
118 - Unit_hipMallocManaged_DeviceContextChange - unsigned char (Failed)
119 - Unit_hipMallocManaged_DeviceContextChange - int (Failed)
120 - Unit_hipMallocManaged_DeviceContextChange - float (Failed)
121 - Unit_hipMallocManaged_DeviceContextChange - double (Failed)
187 - Unit_hipMemcpy_KernelLaunch - int (Failed)
188 - Unit_hipMemcpy_KernelLaunch - float (Failed)
189 - Unit_hipMemcpy_KernelLaunch - double (Failed)
193 - Unit_hipMemcpy_MultiThreadWithSerialization (Subprocess aborted)
197 - Unit_hipMemcpyAsync_KernelLaunch - int (Failed)
198 - Unit_hipMemcpyAsync_KernelLaunch - float (Failed)
199 - Unit_hipMemcpyAsync_KernelLaunch - double (Failed)
204 - Unit_hipMemcpyAsync_hipMultiMemcpyMultiThread - int (Subprocess aborted)
205 - Unit_hipMemcpyAsync_hipMultiMemcpyMultiThread - float (SEGFAULT)
206 - Unit_hipMemcpyAsync_hipMultiMemcpyMultiThread - double (Subprocess aborted)
215 - Unit_ldg (Failed)
450 - Unit_deviceFunctions_CompileTest_modf_double (Failed)
454 - Unit_deviceFunctions_CompileTest_norm_double (Failed)
463 - Unit_deviceFunctions_CompileTest_rhypot_double (Failed)
465 - Unit_deviceFunctions_CompileTest_rnorm_double (Failed)
466 - Unit_deviceFunctions_CompileTest_rnorm3d_double (Failed)
467 - Unit_deviceFunctions_CompileTest_rnorm4d_double (Failed)
474 - Unit_deviceFunctions_CompileTest_sincos_double (Failed)
475 - Unit_deviceFunctions_CompileTest_sincospi_double (Failed)
528 - Unit_hipGetDeviceProperties_ArchPropertiesTst (Failed)
540 - Unit_hipStreamPerThread_MultiThread (Subprocess aborted)
541 - Unit_hipStreamPerThread_DeviceReset_1 (Subprocess aborted)
626 - cuda-reduction (Failed)
Errors while running CTest
—
Reply to this email directly, view it on GitHub
<#135>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACCJBQNYVIOMJ2TKNEF54KLV5HD7JANCNFSM6AAAAAAQHULNIE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
from chipstar.
pvelesko
commented on June 14, 2024
The "Double type is not supported on this platform." is a HW/driver issue
I haven't seen this error before. Are you using an outdated driver? Trying to understand what could cause a failure to emulate.
OpenCL/SPIR-V doesn't require double support or its SW emulation
I thought we enable double support by using #pragma OPENCL EXTENSION cl_khr_fp64 : enable?
Can we fail more gracefully at runtime?
If we fail to compile we throw an error and print the compilation log:
CHIPERR_CHECK_LOG_AND_THROW(Status, ZE_RESULT_SUCCESS, hipErrorTbd);
logError("ZE Build Log: {}", std::string(LogStr).c_str());
besides changing the error from hipErrorTbd to something more specific, how do you propose we make JIT failure more graceful?
from chipstar.
pjaaskel
commented on June 14, 2024
This is an extension, meaning it's not mandatory to support it. I do not know if we can make it more graceful, as long as the user sees it's because of missing capabilities and not just crash, I think there's not much else we can do.
from chipstar.
pjaaskel
commented on June 14, 2024
All of these cases except the one reported in Issue #134 seem to be caused by the double precision issue. I'll change this ticket to fix it for 0.9 via the double precision test tag and another test suite for tests that are not supposed to work with non-double capable HW, and let's leave Issue #137 open for later consideration.
from chipstar.
pjaaskel
commented on June 14, 2024
Not sure if we really need this one as there's a workaround for the only known target where the issue appears.
from chipstar.
pvelesko
commented on June 14, 2024
All testing was done with llvm 14
…On Thu, Sep 8, 2022, 14:34 Pekka Jääskeläinen ***@***.***> wrote:
Have you tested with LLVM 15 or 14?
—
Reply to this email directly, view it on GitHub
<#135 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACCJBQLJ6JJHC7RRMI4WQDTV5HFMBANCNFSM6AAAAAAQHULNIE>
.
You are receiving this because you commented.Message ID:
***@***.***>
from chipstar.
Related Issues (20)
- fatal error: 'sycl/sycl.hpp' when using latest install of oneapi HOT 2
- Build fails on Ubuntu 24.04 HOT 2
- [HIPCC] passing in escaped quotes doesn't work
- [HIPCC] Using -o without providing an object name doesn't work
- configure_llvm.sh does not install chipStar's fork of LLVM
- Use of hipBLAS requires ZE_SERIALIZE=2
- Is CHIP_JIT_FLAGS working as expected? HOT 1
- Naming conflict between built-in functions of CUDA and OCL HOT 5
- [OpenCL] Unit_hipStreamAddCallback_WithDefaultStream Failure on Main
- HIP kernels with bool parameters produce non-conformant SPIR-V
- Enabling HIPBLAS build ends up changing CMAKE_INSTALL_PREFIX for some files HOT 1
- Undefined references when trying to build LTO HOT 5
- Newer hipBLAS.h is not compatible with current `spirv_hip_complex.h` (C compatibility)
- LibCEED failures on CI node
- [OpenCL] CHIP_USE_INTEL_USM option fails on Intel CPU driver HOT 3
- Why we don't account the tail padding when compute a arg'size? HOT 2
- [OpenCL] Sporadic test failures on `main`
- Compiler crash on Sunspot while building chipStar
- Compilation issue for interop samples
- CMake Error for Chipstar Build HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chipstar.